implement new x flag: --skip-std-check-if-no-download-rustc
#141970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <[email protected]>
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
|
This PR modifies If appropriate, please update |
|
r? Kobzol (since you were part of the discussion on Zulip) |
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
onur-ozkan
force-pushed
the
skip-stage1-std
branch
from
50115a0 to
9e162fe
Compare
|
Related: #141955 |
RalfJung
reviewed
Jun 3, 2025
| @@ -60,6 +60,13 @@ impl Step for Std { | |||
| } | |||
|
|
|||
| fn run(self, builder: &Builder<'_>) { | |||
| if !builder.download_rustc() && builder.config.skip_std_check_if_no_download_rustc { | |||
There was a problem hiding this comment.
Does this take into account the "if-unchanged" logic?
|
Thanks a lot for looking into this :-) |
Kobzol
reviewed
Jun 4, 2025
Signed-off-by: onur-ozkan <[email protected]>
|
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
Signed-off-by: onur-ozkan <[email protected]>
onur-ozkan
commented
Jun 4, 2025
Comment on lines
+62
to
+68
| ### Checking the "library" tree | ||
|
|
||
| Checking the "library" tree requires a stage1 compiler, which can be a heavy process on some computers. | ||
| For this reason, bootstrap has a flag called `--skip-std-check-if-no-download-rustc` that skips checking the | ||
| "library" tree if `rust.download-rustc` isn't available. If you want to avoid putting a heavy load on your computer | ||
| with `rust-analyzer`, you can add the `--skip-std-check-if-no-download-rustc` flag to your `./x check` command in | ||
| the `rust-analyzer` configuration. |
There was a problem hiding this comment.
There are too many sample RA configurations. I decided to document this flag separately by its own and leave it to users to decide whether or not to utilize it.
There was a problem hiding this comment.
Ok, fair enough. The main point to get across is that this is only useful when you want to check multiple things (x check compiler library). Otherwise if you check only the library you will always require stage 1.
|
You can r=me once CI is green. |
|
@bors r=Kobzol |
bors
added
S-waiting-on-bors
|
@bors rollup |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 5, 2025
implement new `x` flag: `--skip-std-check-if-no-download-rustc` One of our developers (`@RalfJung)` [reported](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Surprising.20stages.20for.20check.20build.20after.20stage.20reorg/with/521925606)[#t-infra/bootstrap > Surprising stages for check build after stage reorg](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Surprising.20stages.20for.20check.20build.20after.20stage.20reorg/with/521925606) that working on both the compiler and the library simultaneously with RA enabled is extremely difficult because checking library creates a heavy load on machines (by building stage1 compiler) on each modification. `--skip-std-check-if-no-download-rustc` flag is intended to reduce this heavy load on their IDE integration as much as possible. Fixes: rust-lang#141955
bors
added a commit
that referenced
this pull request
Jun 5, 2025
Rollup of 8 pull requests Successful merges: - #140638 (UnsafePinned: also include the effects of UnsafeCell) - #141272 (modularize the config module bootstrap) - #141777 (Do not run PGO/BOLT in x64 Linux alt builds) - #141870 (Fix broken link to rustc_type_ir module in serialization docs) - #141938 (update rust offload bootstrap) - #141962 (rustc-dev-guide subtree update) - #141965 (`tests/ui`: A New Order [3/N]) - #141970 (implement new `x` flag: `--skip-std-check-if-no-download-rustc`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Jun 5, 2025
Rollup of 6 pull requests Successful merges: - #140638 (UnsafePinned: also include the effects of UnsafeCell) - #141777 (Do not run PGO/BOLT in x64 Linux alt builds) - #141938 (update rust offload bootstrap) - #141962 (rustc-dev-guide subtree update) - #141965 (`tests/ui`: A New Order [3/N]) - #141970 (implement new `x` flag: `--skip-std-check-if-no-download-rustc`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 5, 2025
Rollup merge of #141970 - onur-ozkan:skip-stage1-std, r=Kobzol implement new `x` flag: `--skip-std-check-if-no-download-rustc` One of our developers (``@RalfJung)`` [reported](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Surprising.20stages.20for.20check.20build.20after.20stage.20reorg/with/521925606)[#t-infra/bootstrap > Surprising stages for check build after stage reorg](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Surprising.20stages.20for.20check.20build.20after.20stage.20reorg/with/521925606) that working on both the compiler and the library simultaneously with RA enabled is extremely difficult because checking library creates a heavy load on machines (by building stage1 compiler) on each modification. `--skip-std-check-if-no-download-rustc` flag is intended to reduce this heavy load on their IDE integration as much as possible. Fixes: #141955
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our developers (@RalfJung) reported#t-infra/bootstrap > Surprising stages for check build after stage reorg that working on both the compiler and the library simultaneously with RA enabled is extremely difficult because checking library creates a heavy load on machines (by building stage1 compiler) on each modification.
--skip-std-check-if-no-download-rustcflag is intended to reduce this heavy load on their IDE integration as much as possible.Fixes: #141955