Skip to content

Sort error messages by file and line number #36229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
solson opened this issue Sep 2, 2016 · 3 comments
Closed

Sort error messages by file and line number #36229

solson opened this issue Sep 2, 2016 · 3 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@solson
Copy link
Member

solson commented Sep 2, 2016

It would be more clear if error messages were printed out sorted. Say, by filename and then by line within a given file. Currently it seems like they are printed in the order they were emitted, which is mostly arbitrary.

cc @whitequark

@kmcallister kmcallister added A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Sep 2, 2016
@TimNN
Copy link
Contributor

TimNN commented Sep 3, 2016

Related: #32650.

@steveklabnik steveklabnik added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 9, 2017
@Mark-Simulacrum
Copy link
Member

Nominating for compiler team discussion, though I'm inclined to close for similar reasons as #32650 -- it seems unlikely to get implemented and largely impractical; and should be done by an external tool probably.

@nikomatsakis
Copy link
Contributor

Discussed in the compiler team mtg. We agree with @Mark-Simulacrum's assessment. Going to close.

Among other things, buffering up errors is not good (takes a long time to see anything), and in an IDE it's a moot point. I also think that ordering by filename/line is not always what you want either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants