Skip to content

Finish metadata::encoder::encode_info_for_mod #4573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
catamorphism opened this issue Jan 22, 2013 · 4 comments
Closed

Finish metadata::encoder::encode_info_for_mod #4573

catamorphism opened this issue Jan 22, 2013 · 4 comments
Labels
A-metadata Area: Crate metadata C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@catamorphism
Copy link
Contributor

encode_info_for_mod seems to encode whether each module child is exported, but it only does that for impls and structs. So I guess traits all get exported by default? It's unclear to me what needs to be changed, if anything (a FIXME, formerly XXX, just says "Encode these two" for the default case).

@catamorphism
Copy link
Contributor Author

Nominating for milestone 5 (production-ready).

@graydon
Copy link
Contributor

graydon commented May 2, 2013

metadata encoding needs quite a bit of work. put this in a metabug associated with it, and accept for production ready.

@metajack
Copy link
Contributor

revisiting for triage; nothing to add

@pnkfelix
Copy link
Member

pnkfelix commented Feb 6, 2014

We assume this has been done. Closing until someone can show its actually broken with concrete example..

@pnkfelix pnkfelix closed this as completed Feb 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-metadata Area: Crate metadata C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests

4 participants