Skip to content

Send/Sync type parameters come after const parameters in docs #61292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
varkor opened this issue May 28, 2019 · 1 comment · Fixed by #74992
Closed

Send/Sync type parameters come after const parameters in docs #61292

varkor opened this issue May 28, 2019 · 1 comment · Fixed by #74992
Labels
A-const-generics Area: const generics (parameters and arguments) C-bug Category: This is a bug. F-const_generics `#![feature(const_generics)]` requires-nightly This issue requires a nightly compiler in some way. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@varkor
Copy link
Member

varkor commented May 28, 2019

rust/src/test/rustdoc/generic-const.rs

Lines 12 to 13 in 7212685

// @has foo/struct.VSet.html '//h3[@id="impl-Send"]/code' 'impl<const ORDER: Order, T> Send for VSet<T, ORDER>'
// @has foo/struct.VSet.html '//h3[@id="impl-Sync"]/code' 'impl<const ORDER: Order, T> Sync for VSet<T, ORDER>'

Const parameters should always be trailing (at least with respect to type/lifetime parameters). I'm not sure whether this is specifically a rustdoc issue or not yet.
@varkor varkor added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-const-generics Area: const generics (parameters and arguments) labels May 28, 2019
@GuillaumeGomez
Copy link
Member

Strange since we read them as they come... So we have to force their position at the end? Let's go for it then...

@GuillaumeGomez GuillaumeGomez mentioned this issue Jun 2, 2019
Closed
@Centril Centril added F-const_generics `#![feature(const_generics)]` C-bug Category: This is a bug. requires-nightly This issue requires a nightly compiler in some way. labels Aug 6, 2019
@lcnr lcnr mentioned this issue Jul 31, 2020
Merged
@bors bors closed this as completed in 98a9397 Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-const-generics Area: const generics (parameters and arguments) C-bug Category: This is a bug. F-const_generics `#![feature(const_generics)]` requires-nightly This issue requires a nightly compiler in some way. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
3 participants
@Centril @GuillaumeGomez @varkor