Skip to content

Commit bbb25a5

Browse files
committed
ci: Remove incorrect use of continue-on-error
This will cause the CI build to be marked successful even if the build failed. Instead, use `if: '!cancelled()'` to always save the cache (except when the job is cancelled), even if the linkcheck failed. See https://stackoverflow.com/a/58859404 for more.
1 parent 610e80b commit bbb25a5

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

Diff for: .github/workflows/ci.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,10 @@ jobs:
5959
6060
- name: Check build
6161
run: ENABLE_LINKCHECK=1 mdbook build
62-
continue-on-error: true
6362

6463
- name: Save cached Linkcheck
6564
id: cache-linkcheck-save
66-
if: github.event_name == 'schedule'
65+
if: '!cancelled()' && github.event_name == 'schedule'
6766
uses: actions/cache/save@v4
6867
with:
6968
path: book/linkcheck/cache.json

0 commit comments

Comments
 (0)