Skip to content

Commit e20ac5d

Browse files
authored
Add RISC-V notification group instructions (#814)
* Clean-up notification groups instructions * Add RISC-V notification group instructions * Re-order summary of notification groups * Add a list of the notification groups * Apply review suggestion
1 parent 87a11a3 commit e20ac5d

File tree

5 files changed

+43
-10
lines changed

5 files changed

+43
-10
lines changed

src/SUMMARY.md

+3-2
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,11 @@
3737
- [Stabilizing Features](./stabilization_guide.md)
3838
- [Coding conventions](./conventions.md)
3939
- [Notification groups](notification-groups/about.md)
40-
- ["Cleanup Crew"](notification-groups/cleanup-crew.md)
40+
- [ARM](notification-groups/arm.md)
41+
- [Cleanup Crew](notification-groups/cleanup-crew.md)
4142
- [LLVM](notification-groups/llvm.md)
43+
- [RISC-V](notification-groups/risc-v.md)
4244
- [Windows](notification-groups/windows.md)
43-
- [ARM](notification-groups/arm.md)
4445
- [Licenses](./licenses.md)
4546

4647
# High-level Compiler Architecture

src/notification-groups/about.md

+11-1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,15 @@ search for existing issues that haven't been claimed yet.
1616

1717
[claim the issue]: https://github.com/rust-lang/triagebot/wiki/Assignment
1818

19+
## List of notification groups
20+
21+
Here's the list of the notification groups:
22+
- [ARM](./arm.md)
23+
- [Cleanup Crew](./cleanup-crew.md)
24+
- [LLVM](./llvm.md)
25+
- [RISC-V](./risc-v.md)
26+
- [Windows](./windows.md)
27+
1928
## What issues are a good fit for notification groups?
2029

2130
Notification groups tend to get pinged on **isolated** bugs,
@@ -48,10 +57,11 @@ cargo run add-person $your_user_name
4857

4958
Example PRs:
5059

60+
* [Example of adding yourself to the ARM group.](https://github.com/rust-lang/team/pull/358)
5161
* [Example of adding yourself to the Cleanup Crew.](https://github.com/rust-lang/team/pull/221)
5262
* [Example of adding yourself to the LLVM group.](https://github.com/rust-lang/team/pull/140)
63+
* [Example of adding yourself to the RISC-V group.](https://github.com/rust-lang/team/pull/394)
5364
* [Example of adding yourself to the Windows group.](https://github.com/rust-lang/team/pull/348)
54-
* [Example of adding yourself to the ARM group.](https://github.com/rust-lang/team/pull/358)
5565

5666
## Tagging an issue for a notification group
5767

src/notification-groups/arm.md

+3-4
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,15 @@ This list will be used to ask for help both in diagnosing and testing
88
ARM-related issues as well as suggestions on how to resolve
99
interesting questions regarding our ARM support.
1010

11-
The group also has an associated Zulip stream (`#t-compiler/arm`)
11+
The group also has an associated Zulip stream ([`#t-compiler/arm`])
1212
where people can go to pose questions and discuss ARM-specific
1313
topics.
1414

1515
So, if you are interested in participating, please sign up for the
16-
ARM group! To do so, you open a PR against the [rust-lang/team]
16+
ARM group! To do so, open a PR against the [rust-lang/team]
1717
repository. Just [follow this example][eg], but change the username to
1818
your own!
1919

20+
[`#t-compiler/arm`]: https://rust-lang.zulipchat.com/#narrow/stream/242906-t-compiler.2Farm
2021
[rust-lang/team]: https://github.com/rust-lang/team
2122
[eg]: https://github.com/rust-lang/team/pull/358
22-
[#72569]: https://github.com/rust-lang/rust/pull/72569
23-
[#29520]: https://github.com/rust-lang/rust/pull/29520

src/notification-groups/risc-v.md

+22
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# RISC-V notification group
2+
3+
**Github Label:** [O-riscv]
4+
5+
[O-riscv]: https://github.com/rust-lang/rust/labels/O-riscv
6+
7+
This list will be used to ask for help both in diagnosing and testing
8+
RISC-V-related issues as well as suggestions on how to resolve
9+
interesting questions regarding our RISC-V support.
10+
11+
The group also has an associated Zulip stream ([`#t-compiler/risc-v`])
12+
where people can go to pose questions and discuss RISC-V-specific
13+
topics.
14+
15+
So, if you are interested in participating, please sign up for the
16+
RISC-V group! To do so, open a PR against the [rust-lang/team]
17+
repository. Just [follow this example][eg], but change the username to
18+
your own!
19+
20+
[`#t-compiler/risc-v`]: https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v
21+
[rust-lang/team]: https://github.com/rust-lang/team
22+
[eg]: https://github.com/rust-lang/team/pull/394

src/notification-groups/windows.md

+4-3
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ This list will be used to ask for help both in diagnosing and testing
88
Windows-related issues as well as suggestions on how to resolve
99
interesting questions regarding our Windows support.
1010

11-
The group also has an associated Zulip stream (`#t-compiler/windows`)
11+
The group also has an associated Zulip stream ([`#t-compiler/windows`])
1212
where people can go to pose questions and discuss Windows-specific
1313
topics.
1414

@@ -18,13 +18,14 @@ the group for advice in determining the best course of action:
1818

1919
* Which versions of MinGW should we support?
2020
* Should we remove the legacy InnoSetup GUI installer? [#72569]
21-
* What names should we use for static libraries on Windows? [#29520]
21+
* What names should we use for static libraries on Windows? [#29520]
2222

2323
So, if you are interested in participating, please sign up for the
24-
Windows group! To do so, you open a PR against the [rust-lang/team]
24+
Windows group! To do so, open a PR against the [rust-lang/team]
2525
repository. Just [follow this example][eg], but change the username to
2626
your own!
2727

28+
[`#t-compiler/windows`]: https://rust-lang.zulipchat.com/#streams/242869/t-compiler.2Fwindows
2829
[rust-lang/team]: https://github.com/rust-lang/team
2930
[eg]: https://github.com/rust-lang/team/pull/348/
3031
[#72569]: https://github.com/rust-lang/rust/pull/72569

0 commit comments

Comments
 (0)