Skip to content

Commit 6cc9025

Browse files
authored
Merge pull request #2151 from miikkas/more-succinct-bot-msgs
Make some of rust-timer's GitHub messages more succinct
2 parents 36df6da + 740000e commit 6cc9025

File tree

1 file changed

+12
-14
lines changed

1 file changed

+12
-14
lines changed

site/src/github/comparison_summary.rs

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -325,8 +325,8 @@ fn write_metric_summary(
325325
match visibility {
326326
DefaultMetricVisibility::Shown => {
327327
message.push_str(
328-
"This is the most reliable metric that we have; it was used to determine the \
329-
overall result at the top of this comment. However, even this metric can sometimes exhibit noise.\n\n",
328+
"Our most reliable metric. Used to determine the overall result above. \
329+
However, even this metric can be noisy.\n\n",
330330
);
331331
write_summary_table(&primary, &secondary, false, message);
332332
}
@@ -351,8 +351,8 @@ fn write_metric_summary(
351351
// `<details>` means it is hidden, requiring a click to reveal.
352352
message.push_str(&format!("<details>\n<summary>{summary}</summary>\n\n"));
353353
message.push_str(
354-
"This is a less reliable metric that may be of interest but was not \
355-
used to determine the overall result at the top of this comment.\n\n",
354+
"A less reliable metric. May be of interest, but not \
355+
used to determine the overall result above.\n\n",
356356
);
357357
write_summary_table(&primary, &secondary, false, message);
358358
message.push_str("</details>\n");
@@ -392,23 +392,21 @@ cc @rust-lang/wg-compiler-performance
392392
fn try_run_body(is_regression: bool) -> String {
393393
let next_steps = if is_regression {
394394
"\n\n**Next Steps**: If you can justify the regressions found in \
395-
this try perf run, please indicate this with \
396-
`@rustbot label: +perf-regression-triaged` along with \
397-
sufficient written justification. If you cannot justify the regressions \
398-
please fix the regressions and do another perf run. If the next run \
399-
shows neutral or positive results, the label will be automatically removed."
395+
this try perf run, please do so in sufficient writing \
396+
along with `@rustbot label: +perf-regression-triaged`. If not, \
397+
please fix the regressions and do another perf run. If its results \
398+
are neutral or positive, the label will be automatically removed."
400399
} else {
401400
""
402401
};
403402

404403
let sign = if is_regression { "+" } else { "-" };
405404
format!(
406405
"
407-
Benchmarking this pull request likely means that it is \
408-
perf-sensitive, so we're automatically marking it as not fit \
409-
for rolling up. While you can manually mark this PR as fit \
410-
for rollup, we strongly recommend not doing so since this PR may lead to changes in \
411-
compiler perf.{next_steps}
406+
Benchmarking this pull request means it may be perf-sensitive – \
407+
we'll automatically label it not fit for rolling up. \
408+
You can override this, but we strongly advise not to, \
409+
due to possible changes in compiler perf.{next_steps}
412410
413411
@bors rollup=never
414412
@rustbot label: -S-waiting-on-perf {sign}perf-regression",

0 commit comments

Comments
 (0)