Skip to content

ui/issues/issue-28676.rs rustc test fails #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bjorn3 opened this issue Aug 20, 2019 · 2 comments
Closed

ui/issues/issue-28676.rs rustc test fails #682

bjorn3 opened this issue Aug 20, 2019 · 2 comments
Labels
A-abi Area: ABI handling C-bug Category: This is a bug.
Milestone

Comments

@bjorn3
Copy link
Member

bjorn3 commented Aug 20, 2019

thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `140723935210376`,
 right: `3`', ~/cg_clif/rust/src/test/ui/issues/issue-28676.rs:29:9

Probably abi incompatibility with C.

Source code
// run-pass
#![allow(dead_code)]
#![allow(improper_ctypes)]

// ignore-wasm32-bare no libc to test ffi with

#[derive(Copy, Clone)]
pub struct Quad { a: u64, b: u64, c: u64, d: u64 }

mod rustrt {
    use super::Quad;

    #[link(name = "rust_test_helpers", kind = "static")]
    extern {
        pub fn get_c_many_params(_: *const (), _: *const (),
                                 _: *const (), _: *const (), f: Quad) -> u64;
    }
}

fn test() {
    unsafe {
        let null = std::ptr::null();
        let q = Quad {
            a: 1,
            b: 2,
            c: 3,
            d: 4
        };
        assert_eq!(rustrt::get_c_many_params(null, null, null, null, q), q.c);
    }
}

pub fn main() {
    test();
}
@bjorn3 bjorn3 added the C-bug Category: This is a bug. label Aug 20, 2019
@bjorn3 bjorn3 added this to the MVP milestone Aug 20, 2019
@bjorn3
Copy link
Member Author

bjorn3 commented Aug 21, 2019

@bjorn3
Copy link
Member Author

bjorn3 commented Jul 17, 2020

Fixed by #1068

@bjorn3 bjorn3 closed this as completed Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-abi Area: ABI handling C-bug Category: This is a bug.
Projects
None yet
Development

No branches or pull requests

1 participant