Skip to content

Two lines which are individually fine get merged into a line that is too long #2342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shahn opened this issue Jan 5, 2018 · 2 comments
Closed

Two lines which are individually fine get merged into a line that is too long #2342

shahn opened this issue Jan 5, 2018 · 2 comments
Labels
a-comments poor-formatting

Comments

@shahn
Copy link

shahn commented Jan 5, 2018 

    #[cfg(feature = "serde")]
    bytes: [[u8; 17]; 5], // Same size as signature::ED25519_PKCS8_V2_LEN

gets turned into

#[cfg(feature = "serde")] bytes: [[u8; 17]; 5], // Same size as signature::ED25519_PKCS8_V2_LEN

which violates rustfmt settings:

max_width = 80
comment_width = 80
@topecongiro
Copy link
Contributor

cc #2201.

@nrc
Copy link
Member

nrc commented Jan 9, 2018

cc #2208 (comment)

@topecongiro topecongiro mentioned this issue Jan 11, 2018
Merged
@nrc nrc closed this as completed in #2357 Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-comments poor-formatting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shahn @nrc @topecongiro