Skip to content

Add any relevant test cases for reported GAT issues #4969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
calebcartwright opened this issue Aug 30, 2021 · 2 comments · Fixed by #4970
Closed

Add any relevant test cases for reported GAT issues #4969

calebcartwright opened this issue Aug 30, 2021 · 2 comments · Fixed by #4970
Labels
good first issue Issues up for grabs, also good candidates for new rustfmt contributors help wanted

Comments

@calebcartwright
Copy link
Member

We've had a few, and occasionally duplicative, reports of GAT related issues. To the best of my knowledge all the ones we're currently aware of have been resolved but I can't recall if we've added test cases for everything that's been reported. More generally, we could probably use some more tests beyond what's been reported anyway.

For anyone interested in working on this, the tasks will largely consist of:

  • reviewing the various GAT-related reports and checking the current tests (advise looking under tests/target as not all test inputs have a pair file under tests/source). If we're missing cases for any issues and/or if the tests need to be augmented then add/update the test files as needed
  • consider whether there's any additional, untested use cases that should be added. Don't feel obligated to come up with something, but would be good take a look because if there's any remaining gaps/bugs it'd be better to catch them proactively vs. waiting for users to run into them. Remember that context matters when formatting, so e.g. it's possible for rustfmt to handle something correctly in a trait context but have a bug in an impl context.

See https://github.com/rust-lang/rustfmt/blob/master/Contributing.md#create-test-cases for more info on adding test cases

@calebcartwright calebcartwright added good first issue Issues up for grabs, also good candidates for new rustfmt contributors help wanted labels Aug 30, 2021
@calebcartwright
Copy link
Member Author

@raftario - tagging you since in another thread you'd expressed interest in potentially working on this. if that's still the case you can use rustbot to claim the issue to indicate to folks that you're working on it (e.g. @rustbot claim)

@cowboy-bebug
Copy link
Contributor

@calebcartwright @raftario I didn't see the comment above! Apologies 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues up for grabs, also good candidates for new rustfmt contributors help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants