Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfmt on linux crashing with ignore #6185

Open
otiv-emiel-vanseveren opened this issue Jun 5, 2024 · 5 comments
Open

rustfmt on linux crashing with ignore #6185

otiv-emiel-vanseveren opened this issue Jun 5, 2024 · 5 comments
Labels
needs-mcve needs a Minimal Complete and Verifiable Example only-with-option requires a non-default option value to reproduce

Comments

@otiv-emiel-vanseveren
Copy link

command ran:
bazel run @rules_rust//:rustfmt --@rules_rust//:rustfmt.toml=//:rustfmt.toml --output_groups=+rustfmt_checks

rustfmt.toml:
max_width = 100
imports_granularity = "Module"
group_imports = "StdExternalCrate"
ignore = ["third_party/"]

output:
rustc-ice-2024-06-05T14_37_14-130215.txt

@otiv-emiel-vanseveren
Copy link
Author

Managed to pin it down. It is related to the ignore config opt in rustfmt.toml.

@otiv-emiel-vanseveren
Copy link
Author

I suppose it should be part of: #3395?

@ytmimi
Copy link
Contributor

ytmimi commented Jun 5, 2024

@otiv-emiel-vanseveren thanks for the report. I'm personally not familiar with bazel. Is this issue reproducible without using bazel? Also, Do you have a repo you can link to that can be used to reproduce this problem?

@ytmimi ytmimi added only-with-option requires a non-default option value to reproduce needs-mcve needs a Minimal Complete and Verifiable Example labels Jun 5, 2024
@otiv-emiel-vanseveren otiv-emiel-vanseveren changed the title rustfmt crashing when ran with bazel rustfmt on linux crashing with ignore Jun 6, 2024
@otiv-emiel-vanseveren
Copy link
Author

I'll see if I can reproduce it over the weekend.

@otiv-emiel-vanseveren
Copy link
Author

@ytmimi,

Sorry for the late response, I've been a bit busy the last couple of weeks. Here is a reproducible using bazel: https://github.com/emielvanseveren/bazel-rustfmt-ignore. I have not tried with cargo. Steps are in readme!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-mcve needs a Minimal Complete and Verifiable Example only-with-option requires a non-default option value to reproduce
Projects
None yet
Development

No branches or pull requests

2 participants