You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
<p>You'll need to change that to a <code>#[stable]</code> attribute with a version:</p>
188
-
<pre><codeclass="language-rust ignore">#[stable(feature = "total_cmp", since = "1.61.0")]
187
+
<p>You'll need to change that to a <code>#[stable]</code> attribute with the version set to the placeholder <code>CURRENT_RUSTC_VERSION</code>:</p>
188
+
<pre><codeclass="language-rust ignore">#[stable(feature = "total_cmp", since = "CURRENT_RUSTC_VERSION")]
189
189
</code></pre>
190
-
<p>Note that, the version number is updated to be the version number of the stable release where this feature will appear. This can be found by consulting <ahref="https://github.com/rust-lang/rust/blob/master/src/version"><code>src/version</code></a> on the current master branch of <code>rust-lang/rust</code>.</p>
190
+
<p>Note that other <code>#[stable]</code> attributes may contain spelled out version numbers, but you should not spell out any version number as it might get outdated by the time your pull request merges.</p>
191
191
<h3id="remove-feature-gates-from-doctests"><aclass="header" href="#remove-feature-gates-from-doctests">Remove feature gates from doctests</a></h3>
192
192
<p>All the doctests on the items being stabilized will be enabling the unstable feature, so now that it's stable those attributes are no longer needed and should be removed.</p>
<li>Create a stabiliation report in the tracking issue for the feature being stabilized.</li>
214
214
<li>(Optional) For partial stabilizations, create a new partial stabilization PR for the subset of the issue being stabilized.</li>
215
215
<li>Ask a <strong>@rust-lang/libs-api</strong> member to start an FCP on the tracking issue and wait for the FCP to complete (with <code>disposition-merge</code>).</li>
216
-
<li>Change <code>#[unstable(...)]</code> to <code>#[stable(since = "version")]</code>. <code>version</code>should be the <em>current nightly</em>, i.e. stable+2. You can see which version is the current nightly in <ahref="https://github.com/rust-lang/rust/blob/master/src/version"><code>src/version</code></a> on the master branch of <code>rust-lang/rust</code>.</li>
216
+
<li>Change <code>#[unstable(...)]</code> to <code>#[stable(since = "CURRENT_RUSTC_VERSION")]</code>. <code>CURRENT_RUSTC_VERSION</code>here is meant in a literal sense and not to be replaced with the spelled out version number.</li>
217
217
<li>Remove <code>#![feature(...)]</code> from any test or doc-test for this API. If the feature is used in the compiler or tools, remove it from there as well.</li>
218
-
<li>If applicable, change <code>#[rustc_const_unstable(...)]</code> to <code>#[rustc_const_stable(since = "version")]</code>.</li>
218
+
<li>If applicable, change <code>#[rustc_const_unstable(...)]</code> to <code>#[rustc_const_stable(since = "CURRENT_RUSTC_VERSION")]</code>.</li>
219
219
<li>Open a PR against <code>rust-lang/rust</code>.
220
220
<ul>
221
221
<li>Add the appropriate labels: <code>@rustbot modify labels: +T-libs-api</code>.</li>
<p>You'll need to change that to a <code>#[stable]</code> attribute with a version:</p>
401
-
<pre><codeclass="language-rust ignore">#[stable(feature = "total_cmp", since = "1.61.0")]
400
+
<p>You'll need to change that to a <code>#[stable]</code> attribute with the version set to the placeholder <code>CURRENT_RUSTC_VERSION</code>:</p>
401
+
<pre><codeclass="language-rust ignore">#[stable(feature = "total_cmp", since = "CURRENT_RUSTC_VERSION")]
402
402
</code></pre>
403
-
<p>Note that, the version number is updated to be the version number of the stable release where this feature will appear. This can be found by consulting <ahref="https://github.com/rust-lang/rust/blob/master/src/version"><code>src/version</code></a> on the current master branch of <code>rust-lang/rust</code>.</p>
403
+
<p>Note that other <code>#[stable]</code> attributes may contain spelled out version numbers, but you should not spell out any version number as it might get outdated by the time your pull request merges.</p>
404
404
<h3id="remove-feature-gates-from-doctests"><aclass="header" href="#remove-feature-gates-from-doctests">Remove feature gates from doctests</a></h3>
405
405
<p>All the doctests on the items being stabilized will be enabling the unstable feature, so now that it's stable those attributes are no longer needed and should be removed.</p>
<li>Create a stabiliation report in the tracking issue for the feature being stabilized.</li>
427
427
<li>(Optional) For partial stabilizations, create a new partial stabilization PR for the subset of the issue being stabilized.</li>
428
428
<li>Ask a <strong>@rust-lang/libs-api</strong> member to start an FCP on the tracking issue and wait for the FCP to complete (with <code>disposition-merge</code>).</li>
429
-
<li>Change <code>#[unstable(...)]</code> to <code>#[stable(since = "version")]</code>. <code>version</code>should be the <em>current nightly</em>, i.e. stable+2. You can see which version is the current nightly in <ahref="https://github.com/rust-lang/rust/blob/master/src/version"><code>src/version</code></a> on the master branch of <code>rust-lang/rust</code>.</li>
429
+
<li>Change <code>#[unstable(...)]</code> to <code>#[stable(since = "CURRENT_RUSTC_VERSION")]</code>. <code>CURRENT_RUSTC_VERSION</code>here is meant in a literal sense and not to be replaced with the spelled out version number.</li>
430
430
<li>Remove <code>#![feature(...)]</code> from any test or doc-test for this API. If the feature is used in the compiler or tools, remove it from there as well.</li>
431
-
<li>If applicable, change <code>#[rustc_const_unstable(...)]</code> to <code>#[rustc_const_stable(since = "version")]</code>.</li>
431
+
<li>If applicable, change <code>#[rustc_const_unstable(...)]</code> to <code>#[rustc_const_stable(since = "CURRENT_RUSTC_VERSION")]</code>.</li>
432
432
<li>Open a PR against <code>rust-lang/rust</code>.
433
433
<ul>
434
434
<li>Add the appropriate labels: <code>@rustbot modify labels: +T-libs-api</code>.</li>
0 commit comments