Merge pull request #449 from Freax13/enhancement/remove-deprecate

remove deprecated from_bits_unchecked functions

Author: Freax13

src/registers/control.rs

@@ -51,14 +51,6 @@ bitflags! {
     }
 }
 
-impl Cr0Flags {
-    #[deprecated = "use the safe `from_bits_retain` method instead"]
-    /// Convert from underlying bit representation, preserving all bits (even those not corresponding to a defined flag).
-    pub const unsafe fn from_bits_unchecked(bits: u64) -> Self {
-        Self::from_bits_retain(bits)
-    }
-}
-
 /// Contains the Page Fault Linear Address (PFLA).
 ///
 /// When a page fault occurs, the CPU sets this register to the faulting virtual address.
@@ -82,14 +74,6 @@ bitflags! {
     }
 }
 
-impl Cr3Flags {
-    #[deprecated = "use the safe `from_bits_retain` method instead"]
-    /// Convert from underlying bit representation, preserving all bits (even those not corresponding to a defined flag).
-    pub const unsafe fn from_bits_unchecked(bits: u64) -> Self {
-        Self::from_bits_retain(bits)
-    }
-}
-
 /// Contains various control flags that enable architectural extensions, and
 /// indicate support for specific processor capabilities.
 #[derive(Debug)]
@@ -175,14 +159,6 @@ bitflags! {
     }
 }
 
-impl Cr4Flags {
-    #[deprecated = "use the safe `from_bits_retain` method instead"]
-    /// Convert from underlying bit representation, preserving all bits (even those not corresponding to a defined flag).
-    pub const unsafe fn from_bits_unchecked(bits: u64) -> Self {
-        Self::from_bits_retain(bits)
-    }
-}
-
 #[cfg(feature = "instructions")]
 mod x86_64 {
     use super::*;

src/registers/debug.rs

@@ -160,12 +160,6 @@ impl Dr6Flags {
             DebugAddressRegisterNumber::Dr3 => Self::TRAP3,
         }
     }
-
-    #[deprecated = "use the safe `from_bits_retain` method instead"]
-    /// Convert from underlying bit representation, preserving all bits (even those not corresponding to a defined flag).
-    pub const unsafe fn from_bits_unchecked(bits: u64) -> Self {
-        Self::from_bits_retain(bits)
-    }
 }
 
 bitflags! {
@@ -239,12 +233,6 @@ impl Dr7Flags {
             DebugAddressRegisterNumber::Dr3 => Self::GLOBAL_BREAKPOINT_3_ENABLE,
         }
     }
-
-    #[deprecated = "use the safe `from_bits_retain` method instead"]
-    /// Convert from underlying bit representation, preserving all bits (even those not corresponding to a defined flag).
-    pub const unsafe fn from_bits_unchecked(bits: u64) -> Self {
-        Self::from_bits_retain(bits)
-    }
 }
 
 /// The condition for a hardware breakpoint.

src/registers/model_specific.rs

@@ -132,14 +132,6 @@ bitflags! {
     }
 }
 
-impl EferFlags {
-    #[deprecated = "use the safe `from_bits_retain` method instead"]
-    /// Convert from underlying bit representation, preserving all bits (even those not corresponding to a defined flag).
-    pub const unsafe fn from_bits_unchecked(bits: u64) -> Self {
-        Self::from_bits_retain(bits)
-    }
-}
-
 bitflags! {
     /// Flags stored in IA32_U_CET and IA32_S_CET (Table-2-2 in Intel SDM Volume
     /// 4). The Intel SDM-equivalent names are described in parentheses.
@@ -165,14 +157,6 @@ bitflags! {
     }
 }
 
-impl CetFlags {
-    #[deprecated = "use the safe `from_bits_retain` method instead"]
-    /// Convert from underlying bit representation, preserving all bits (even those not corresponding to a defined flag).
-    pub const unsafe fn from_bits_unchecked(bits: u64) -> Self {
-        Self::from_bits_retain(bits)
-    }
-}
-
 #[cfg(feature = "instructions")]
 mod x86_64 {
     use super::*;

src/registers/mxcsr.rs

@@ -60,14 +60,6 @@ impl Default for MxCsr {
     }
 }
 
-impl MxCsr {
-    #[deprecated = "use the safe `from_bits_retain` method instead"]
-    /// Convert from underlying bit representation, preserving all bits (even those not corresponding to a defined flag).
-    pub const unsafe fn from_bits_unchecked(bits: u32) -> Self {
-        Self::from_bits_retain(bits)
-    }
-}
-
 #[cfg(feature = "instructions")]
 mod x86_64 {
     use super::*;

src/registers/rflags.rs

@@ -64,14 +64,6 @@ bitflags! {
     }
 }
 
-impl RFlags {
-    #[deprecated = "use the safe `from_bits_retain` method instead"]
-    /// Convert from underlying bit representation, preserving all bits (even those not corresponding to a defined flag).
-    pub const unsafe fn from_bits_unchecked(bits: u64) -> Self {
-        Self::from_bits_retain(bits)
-    }
-}
-
 #[cfg(feature = "instructions")]
 mod x86_64 {
     use super::*;

src/registers/xcontrol.rs

@@ -50,14 +50,6 @@ bitflags! {
     }
 }
 
-impl XCr0Flags {
-    #[deprecated = "use the safe `from_bits_retain` method instead"]
-    /// Convert from underlying bit representation, preserving all bits (even those not corresponding to a defined flag).
-    pub const unsafe fn from_bits_unchecked(bits: u64) -> Self {
-        Self::from_bits_retain(bits)
-    }
-}
-
 #[cfg(feature = "instructions")]
 mod x86_64 {
     use super::*;

src/structures/gdt.rs

@@ -357,12 +357,6 @@ impl DescriptorFlags {
     /// A 64-bit user code segment
     pub const USER_CODE64: Self =
         Self::from_bits_truncate(Self::KERNEL_CODE64.bits() | Self::DPL_RING_3.bits());
-
-    #[deprecated = "use the safe `from_bits_retain` method instead"]
-    /// Convert from underlying bit representation, preserving all bits (even those not corresponding to a defined flag).
-    pub const unsafe fn from_bits_unchecked(bits: u64) -> Self {
-        Self::from_bits_retain(bits)
-    }
 }
 
 impl Descriptor {

src/structures/idt.rs

@@ -1115,14 +1115,6 @@ bitflags! {
     }
 }
 
-impl PageFaultErrorCode {
-    #[deprecated = "use the safe `from_bits_retain` method instead"]
-    /// Convert from underlying bit representation, preserving all bits (even those not corresponding to a defined flag).
-    pub const unsafe fn from_bits_unchecked(bits: u64) -> Self {
-        Self::from_bits_retain(bits)
-    }
-}
-
 /// Describes an error code referencing a segment selector.
 #[derive(Clone, Copy, PartialEq, Eq, Hash)]
 #[repr(transparent)]

src/structures/paging/page_table.rs

@@ -169,14 +169,6 @@ bitflags! {
     }
 }
 
-impl PageTableFlags {
-    #[deprecated = "use the safe `from_bits_retain` method instead"]
-    /// Convert from underlying bit representation, preserving all bits (even those not corresponding to a defined flag).
-    pub const unsafe fn from_bits_unchecked(bits: u64) -> Self {
-        Self::from_bits_retain(bits)
-    }
-}
-
 /// The number of entries in a page table.
 const ENTRY_COUNT: usize = 512;