Skip to content

Update rustls version to 0.5.8 to make it work with nightly compiler. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timgluz opened this issue Apr 18, 2017 · 2 comments
Closed

Comments

@timgluz
Copy link

timgluz commented Apr 18, 2017

Hi,

thanks for your library! I'm using it to get around of OpenSSL nightmares on different platforms.

I encountered a compiler error when i tried to compile my project with nightly rustc.
Error is caused by old version of rustls, which is using unknown compiler feature #[export_macro]. That issue is now fixed in 0.5.8 . source: rustls/rustls#55

Is it welcome to submit PR that upgrades just that dependency?
ps: I'm not in hurry and i can wait for next release.

@bruceadams
Copy link

@timgluz The dependency here on rustls is rustls = "0.5.6" which allows for higher minor versions, including 0.5.8. Can you try doing cargo update in your project that uses hyper-rustls?

For what it's worth, my project https://github.com/bruceadams/wdsapi depends on hyper-rustls and my concrete use (where I have Cargo.lock checked into source control) is in https://github.com/bruceadams/wdscli, see https://github.com/bruceadams/wdscli/blob/master/Cargo.lock#L105:L112 which shows rustls 0.5.8 as a dependency of hyper-rustls.

@timgluz
Copy link
Author

timgluz commented Apr 18, 2017

Hi,

thanks. It worked.

@timgluz timgluz closed this as completed Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants