Skip to content

File API Library #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rylev opened this issue Mar 24, 2019 · 4 comments · Fixed by #110
Closed

File API Library #47

rylev opened this issue Mar 24, 2019 · 4 comments · Fixed by #110
Labels
needs implementation A design proposal RFC has been accepted, and now needs an implementation
Milestone
0.1 initial release

Comments

@rylev
Copy link
Collaborator

rylev commented Mar 24, 2019

Let's make an idiomatic, Rust-y interface to the file API!

https://w3c.github.io/FileAPI/
@rylev
Copy link
Collaborator Author

rylev commented Mar 24, 2019

@fitzgen I'd like to take this on. I think the mid-level API should be pretty straight forward translation of the raw APIs with the following changes:

  • remove all JSValue's (e.g., translate exceptions to bespoke error types)
  • callbacks take the appropriate closure types
  • Builder types instead of overloaded constructor functions

Should I make an official proposal for this and expand on these points?

@fitzgen
Copy link
Member

fitzgen commented Mar 25, 2019

Should I make an official proposal for this and expand on these points?

Yes please!

@rylev rylev mentioned this issue Mar 25, 2019
Closed
@fitzgen
Copy link
Member

fitzgen commented May 10, 2019

Now that #50 is merged, this is ready for implementation!

Were you planning on doing the implementation as well, @rylev?

@fitzgen fitzgen added this to the 0.1 initial release milestone May 10, 2019
@fitzgen fitzgen added the needs implementation A design proposal RFC has been accepted, and now needs an implementation label May 10, 2019
@rylev
Copy link
Collaborator Author

rylev commented May 12, 2019

Yep. I'm away for a few days but will do it at the end of the week

@richard-uk1 richard-uk1 mentioned this issue Jan 18, 2020
Open
@richard-uk1 richard-uk1 mentioned this issue Feb 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs implementation A design proposal RFC has been accepted, and now needs an implementation
Projects
None yet
Milestone
0.1 initial release
Development

Successfully merging a pull request may close this issue.

Files implementation richard-uk1/gloo
2 participants
@fitzgen @rylev