Committing accumulated changes.

Author: rwgk

SConscript

@@ -34,10 +34,11 @@ elif build_config_compiler == "linux_gcc":
 std_opt = ["-std=%s" % pybind11_build_config["cxx_std"]]
 vis_opt = ["-fvisibility=hidden"]
 opt_opt = ["-O0", "-g"]
-wrn_opt = ["-Wall", "-Wextra", "-Wconversion", "-Wcast-qual", "-Wdeprecated", "-Wnon-virtual-dtor", "-Wunused-result"]
+wrn_opt = ["-Wall", "-Wextra", "-Wconversion", "-Wcast-qual", "-Wdeprecated", "-Wnon-virtual-dtor", "-Wunused-result", "-Werror"]
 
 extra_defines = arguments_get_split("extra_defines")
 extra_defines.append("PYBIND11_STRICT_ASSERTS_CLASS_HOLDER_VS_TYPE_CASTER_MIX")
+extra_defines.append("PYBIND11_ENABLE_TYPE_CASTER_ODR_GUARD_IF_AVAILABLE")
 
 def process_meta_opts():
   meta_opts = arguments_get_split("meta_opts")
@@ -122,12 +123,18 @@ for main_module in [
     "class_sh_module_local_0",
     "class_sh_module_local_1",
     "class_sh_module_local_2",
+    "namespace_visibility_2",
 ]:
   if Glob("#pybind11/tests/%s.cpp" % main_module):
     pybind11_tests_shared_library(
         target="#lib/%s" % main_module,
         sources=["%s.cpp" % main_module])
 
+if Glob("#pybind11/tests/namespace_visibility_1.cpp"):
+  pybind11_tests_shared_library(
+      target="#lib/namespace_visibility_1",
+      sources=["namespace_visibility_1.cpp", "namespace_visibility_1s.cpp"])
+
 env_base.Clone(
     CPPDEFINES = extra_defines,
     CPPPATH=["#pybind11/include",
@@ -144,7 +151,7 @@ env_base.Clone(
              python_include,
              "#Catch2/single_include/catch2"],
     CXXFLAGS=std_opt + opt_opt + wrn_opt,
-    LINKFLAGS=["-rdynamic"] + opt_opt,
+    LINKFLAGS=["-Llib", "-rdynamic"] + opt_opt,
     LIBS=[python_lib, "pthread", "dl", "util"]).Program(
         target="#bin/test_embed",
         source=build_paths_in_subdir(

run_tests.py

@@ -14,7 +14,8 @@ def build_list_of_tests(tests_dirpath, substrings):
   """."""
   all_test_py = []
   for node in os.listdir(tests_dirpath):
-    if node.startswith("test_class_sh_") and node.endswith(".py"):
+    if ((node.startswith("test_class_sh_") and node.endswith(".py")) or
+        node == "test_exc_namespace_visibility.py"):
       all_test_py.append(node)
       continue
     if not node.startswith("test_") or not node.endswith(".cpp"):
@@ -134,7 +135,7 @@ def run(args):
   tests_dirpath = os.path.join(pybind11_dirpath, "tests")
   test_embed_dirpath = os.path.join(tests_dirpath, "test_embed")
   test_embed, list_of_test_py = build_list_of_tests(tests_dirpath, substrings)
-  env = {"PYTHONPATH": normabspath("lib")}
+  env = {"PYTHONPATH": normabspath("lib") + ":/foo/bar"}
   if test_embed:
     print('Running tests in directory "%s":' % test_embed_dirpath)
     sys.stdout.flush()