Skip to content

Commit 8ed2925

Browse files
committed
Propagate Errors in DefaultHttpRequestBuilder
This commit introduces the new `WebClientException` for wrapping client-side exceptions. This exception is now thrown when now message encoder can be found for writing the request body as an HTTP request message. Fixes spring-projects#83
1 parent e2a0765 commit 8ed2925

File tree

2 files changed

+38
-3
lines changed

2 files changed

+38
-3
lines changed

spring-web-reactive/src/main/java/org/springframework/web/client/reactive/DefaultHttpRequestBuilder.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -170,10 +170,9 @@ public ClientHttpRequest build(ClientHttpRequestFactory factory) {
170170
mediaType));
171171
}
172172
else {
173-
// TODO: wrap with client exception?
174-
request.setBody(Flux.error(new IllegalStateException("Can't write request body" +
173+
throw new WebClientException("Can't write request body " +
175174
"of type '" + requestBodyType.toString() +
176-
"' for content-type '" + mediaType.toString() + "'")));
175+
"' for content-type '" + mediaType.toString() + "'");
177176
}
178177
}
179178

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
/*
2+
* Copyright 2002-2016 the original author or authors.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* http://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
17+
package org.springframework.web.client.reactive;
18+
19+
import org.springframework.core.NestedRuntimeException;
20+
21+
/**
22+
* Base class for exceptions thrown by {@link WebClient} whenever
23+
* it encounters client-side errors.
24+
*
25+
* @author Brian Clozel
26+
*/
27+
public class WebClientException extends NestedRuntimeException {
28+
29+
public WebClientException(String msg) {
30+
super(msg);
31+
}
32+
33+
public WebClientException(String msg, Throwable cause) {
34+
super(msg, cause);
35+
}
36+
}

0 commit comments

Comments
 (0)