Skip to content

Commit 1e346b3

Browse files
Apply suggestions from Dave Morris
Co-authored-by: DaveWitteMorris <[email protected]>
1 parent c960011 commit 1e346b3

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/sage/arith/misc.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3648,7 +3648,7 @@ def CRT_basis(moduli, *, require_coprime_moduli=True):
36483648
extended Euclidean algorithm
36493649
36503650
- ``require_coprime_moduli`` -- boolean (default: ``True``); whether the moduli
3651-
must be coprime.
3651+
must be pairwise coprime.
36523652
36533653
OUTPUT:
36543654
@@ -3698,13 +3698,13 @@ def CRT_basis(moduli, *, require_coprime_moduli=True):
36983698
return [cs, True]
36993699
except ValueError:
37003700
if require_coprime_moduli:
3701-
raise ValueError('moduli must be coprime')
3701+
raise
37023702
e = [1]
37033703
M_i = moduli[0]
37043704
for i in range(1, n):
37053705
m_i = moduli[i]
37063706
d_i = gcd(M_i, m_i)
3707-
e_i = CRT(0, 1, M_i / d_i, m_i / d_i)
3707+
e_i = CRT(0, 1, M_i // d_i, m_i // d_i)
37083708
e.append(e_i)
37093709
M_i = M_i.lcm(m_i)
37103710
partial_prod_table = [1]
@@ -3757,12 +3757,12 @@ def CRT_vectors(X, moduli):
37573757
raise ValueError("number of moduli must equal length of X")
37583758
res = CRT_basis(moduli, require_coprime_moduli=False)
37593759
a = res[0]
3760-
modulus = prod(moduli)
3760+
modulus = lcm(moduli)
37613761
candidate = [sum(a[i] * X[i][j] for i in range(n)) % modulus
37623762
for j in range(len(X[0]))]
37633763
if not res[1] and any(X[i][j] != candidate[j] % moduli[i] for i in range(n)
3764-
for j in range(len(X[i]))):
3765-
raise ValueError("solution does not exist")
3764+
for j in range(len(X[i]))):
3765+
raise ValueError("solution does not exist")
37663766
return candidate
37673767

37683768
def binomial(x, m, **kwds):

0 commit comments

Comments
 (0)