Skip to content

Commit 8a355d2

Browse files
author
Release Manager
committed
gh-35377: build/pkgs/openblas/spkg-configure.m4: Reject version 0.3.22 <!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description openblas 0.3.22 is broken, see: - #35371 - scipy/scipy#18208 - OpenMathLib/OpenBLAS#3976 We reject it. <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35377 Reported by: Matthias Köppe Reviewer(s): John H. Palmieri
2 parents 519b62c + 200c626 commit 8a355d2

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

build/pkgs/openblas/spkg-configure.m4

+13-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,12 @@ SAGE_SPKG_CONFIGURE([openblas], [
77
m4_pushdef([SAGE_OPENBLAS_MIN_VERSION_MINOR], [2])
88
m4_pushdef([SAGE_OPENBLAS_MIN_VERSION_MICRO], [20])
99
m4_pushdef([SAGE_OPENBLAS_MIN_VERSION], [SAGE_OPENBLAS_MIN_VERSION_MAJOR.SAGE_OPENBLAS_MIN_VERSION_MINOR.SAGE_OPENBLAS_MIN_VERSION_MICRO])
10-
PKG_CHECK_MODULES([OPENBLAS], [openblas >= ]SAGE_OPENBLAS_MIN_VERSION, [
10+
dnl Reject openblas 0.3.22 - https://github.com/sagemath/sage/pull/35371
11+
m4_pushdef([SAGE_OPENBLAS_LT_VERSION_MAJOR], [0])
12+
m4_pushdef([SAGE_OPENBLAS_LT_VERSION_MINOR], [3])
13+
m4_pushdef([SAGE_OPENBLAS_LT_VERSION_MICRO], [22])
14+
m4_pushdef([SAGE_OPENBLAS_LT_VERSION], [SAGE_OPENBLAS_LT_VERSION_MAJOR.SAGE_OPENBLAS_LT_VERSION_MINOR.SAGE_OPENBLAS_LT_VERSION_MICRO])
15+
PKG_CHECK_MODULES([OPENBLAS], [openblas >= ]SAGE_OPENBLAS_MIN_VERSION [openblas < ]SAGE_OPENBLAS_LT_VERSION, [
1116
LIBS="$OPENBLAS_LIBS $LIBS"
1217
CFLAGS="$OPENBLAS_CFLAGS $CFLAGS"
1318
PKG_CHECK_VAR([OPENBLASPCDIR], [openblas], [pcfiledir], [
@@ -74,6 +79,13 @@ SAGE_SPKG_CONFIGURE([openblas], [
7479
< 10000 * ]]SAGE_OPENBLAS_MIN_VERSION_MAJOR[[
7580
+ 100 * ]]SAGE_OPENBLAS_MIN_VERSION_MINOR[[
7681
+ ]]SAGE_OPENBLAS_MIN_VERSION_MICRO[[)
82+
return 1;
83+
if ( 10000 * version[0]
84+
+ 100 * version[1]
85+
+ version[2]
86+
>=10000 * ]]SAGE_OPENBLAS_LT_VERSION_MAJOR[[
87+
+ 100 * ]]SAGE_OPENBLAS_LT_VERSION_MINOR[[
88+
+ ]]SAGE_OPENBLAS_LT_VERSION_MICRO[[)
7789
return 1;]])
7890
], [AS_VAR_SET([HAVE_OPENBLAS], [yes])], [AS_VAR_SET([HAVE_OPENBLAS], [no])],
7991
[AS_VAR_SET([HAVE_OPENBLAS], [yes])])

0 commit comments

Comments
 (0)