Skip to content

Commit 57e212e

Browse files
VietND96sandeepsuryaprasad
authored andcommitted
[grid] Set session-request-timeout as client readTimeout in RemoteNewSessionQueue (SeleniumHQ#14272)
Signed-off-by: Viet Nguyen Duc <[email protected]>
1 parent cc8f4a4 commit 57e212e

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

java/src/org/openqa/selenium/grid/sessionqueue/remote/RemoteNewSessionQueue.java

+7-1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
package org.openqa.selenium.grid.sessionqueue.remote;
1919

20+
import static org.openqa.selenium.remote.http.ClientConfig.defaultConfig;
2021
import static org.openqa.selenium.remote.http.HttpMethod.DELETE;
2122
import static org.openqa.selenium.remote.http.HttpMethod.GET;
2223
import static org.openqa.selenium.remote.http.HttpMethod.POST;
@@ -25,6 +26,7 @@
2526
import java.lang.reflect.Type;
2627
import java.net.MalformedURLException;
2728
import java.net.URI;
29+
import java.time.Duration;
2830
import java.util.HashMap;
2931
import java.util.List;
3032
import java.util.Map;
@@ -48,6 +50,7 @@
4850
import org.openqa.selenium.internal.Require;
4951
import org.openqa.selenium.json.Json;
5052
import org.openqa.selenium.json.TypeToken;
53+
import org.openqa.selenium.remote.http.ClientConfig;
5154
import org.openqa.selenium.remote.http.Contents;
5255
import org.openqa.selenium.remote.http.Filter;
5356
import org.openqa.selenium.remote.http.HttpClient;
@@ -77,14 +80,17 @@ public RemoteNewSessionQueue(Tracer tracer, HttpClient client, Secret registrati
7780
public static NewSessionQueue create(Config config) {
7881
Tracer tracer = new LoggingOptions(config).getTracer();
7982
URI uri = new NewSessionQueueOptions(config).getSessionQueueUri();
83+
Duration sessionRequestTimeout = new NewSessionQueueOptions(config).getSessionRequestTimeout();
8084
HttpClient.Factory clientFactory = new NetworkOptions(config).getHttpClientFactory(tracer);
8185

8286
SecretOptions secretOptions = new SecretOptions(config);
8387
Secret registrationSecret = secretOptions.getRegistrationSecret();
8488

8589
try {
90+
ClientConfig clientConfig =
91+
defaultConfig().readTimeout(sessionRequestTimeout).baseUrl(uri.toURL());
8692
return new RemoteNewSessionQueue(
87-
tracer, clientFactory.createClient(uri.toURL()), registrationSecret);
93+
tracer, clientFactory.createClient(clientConfig), registrationSecret);
8894
} catch (MalformedURLException e) {
8995
throw new UncheckedIOException(e);
9096
}

0 commit comments

Comments
 (0)