Skip to content

Commit 6f4508b

Browse files
RenderMichaelsandeepsuryaprasad
authored andcommitted
[dotnet] Annotate nullability on WebDriver.SessionId (SeleniumHQ#15350)
1 parent a2c6c41 commit 6f4508b

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

dotnet/src/webdriver/IHasSessionId.cs

+2
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
// under the License.
1818
// </copyright>
1919

20+
#nullable enable
21+
2022
namespace OpenQA.Selenium
2123
{
2224
/// <summary>

dotnet/src/webdriver/WebDriver.cs

+3-7
Original file line numberDiff line numberDiff line change
@@ -184,13 +184,13 @@ public ReadOnlyCollection<string> WindowHandles
184184
/// </summary>
185185
public bool IsActionExecutor => true;
186186

187+
#nullable enable
188+
187189
/// <summary>
188-
/// Gets the <see cref="SessionId"/> for the current session of this driver.
190+
/// Gets the <see cref="Selenium.SessionId"/> for the current session of this driver.
189191
/// </summary>
190192
public SessionId SessionId { get; private set; }
191193

192-
#nullable enable
193-
194194
/// <summary>
195195
/// Gets or sets the <see cref="IFileDetector"/> responsible for detecting
196196
/// sequences of keystrokes representing file paths and names.
@@ -715,8 +715,6 @@ protected bool RegisterInternalDriverCommand(string commandName, [NotNullWhen(tr
715715
return this.RegisterDriverCommand(commandName, commandInfo, true);
716716
}
717717

718-
#nullable restore
719-
720718
/// <summary>
721719
/// Stops the client from running
722720
/// </summary>
@@ -747,8 +745,6 @@ protected virtual void Dispose(bool disposing)
747745
this.CommandExecutor.Dispose();
748746
}
749747

750-
#nullable enable
751-
752748
private static void UnpackAndThrowOnError(Response errorResponse, string commandToExecute)
753749
{
754750
// Check the status code of the error, and only handle if not success.

0 commit comments

Comments
 (0)