Skip to content

Commit dc64ffe

Browse files
nvborisenkosandeepsuryaprasad
authored andcommitted
[dotnet][bidi] Add BrowsingContext.OnNavigationCommitted event (SeleniumHQ#15253)
1 parent ad1ca46 commit dc64ffe

File tree

2 files changed

+22
-2
lines changed

2 files changed

+22
-2
lines changed

dotnet/src/webdriver/BiDi/Modules/BrowsingContext/BrowsingContext.cs

+12-2
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,11 @@ public Task<Subscription> OnDomContentLoadedAsync(Func<NavigationInfo, Task> han
154154
return BiDi.BrowsingContext.OnDomContentLoadedAsync(handler, new BrowsingContextsSubscriptionOptions(options) { Contexts = [this] });
155155
}
156156

157+
public Task<Subscription> OnDomContentLoadedAsync(Action<NavigationInfo> handler, SubscriptionOptions? options = null)
158+
{
159+
return BiDi.BrowsingContext.OnDomContentLoadedAsync(handler, new BrowsingContextsSubscriptionOptions(options) { Contexts = [this] });
160+
}
161+
157162
public Task<Subscription> OnLoadAsync(Action<NavigationInfo> handler, SubscriptionOptions? options = null)
158163
{
159164
return BiDi.BrowsingContext.OnLoadAsync(handler, new BrowsingContextsSubscriptionOptions(options) { Contexts = [this] });
@@ -194,9 +199,14 @@ public Task<Subscription> OnNavigationFailedAsync(Func<NavigationInfo, Task> han
194199
return BiDi.BrowsingContext.OnNavigationFailedAsync(handler, new BrowsingContextsSubscriptionOptions(options) { Contexts = [this] });
195200
}
196201

197-
public Task<Subscription> OnDomContentLoadedAsync(Action<NavigationInfo> handler, SubscriptionOptions? options = null)
202+
public Task<Subscription> OnNavigationCommittedAsync(Action<NavigationInfo> handler, SubscriptionOptions? options = null)
198203
{
199-
return BiDi.BrowsingContext.OnDomContentLoadedAsync(handler, new BrowsingContextsSubscriptionOptions(options) { Contexts = [this] });
204+
return BiDi.BrowsingContext.OnNavigationCommittedAsync(handler, new BrowsingContextsSubscriptionOptions(options) { Contexts = [this] });
205+
}
206+
207+
public Task<Subscription> OnNavigationCommittedAsync(Func<NavigationInfo, Task> handler, SubscriptionOptions? options = null)
208+
{
209+
return BiDi.BrowsingContext.OnNavigationCommittedAsync(handler, new BrowsingContextsSubscriptionOptions(options) { Contexts = [this] });
200210
}
201211

202212
public override bool Equals(object? obj)

dotnet/src/webdriver/BiDi/Modules/BrowsingContext/BrowsingContextModule.cs

+10
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,16 @@ public async Task<Subscription> OnNavigationFailedAsync(Action<NavigationInfo> h
247247
return await Broker.SubscribeAsync("browsingContext.navigationFailed", handler, options).ConfigureAwait(false);
248248
}
249249

250+
public async Task<Subscription> OnNavigationCommittedAsync(Func<NavigationInfo, Task> handler, BrowsingContextsSubscriptionOptions? options = null)
251+
{
252+
return await Broker.SubscribeAsync("browsingContext.navigationCommitted", handler, options).ConfigureAwait(false);
253+
}
254+
255+
public async Task<Subscription> OnNavigationCommittedAsync(Action<NavigationInfo> handler, BrowsingContextsSubscriptionOptions? options = null)
256+
{
257+
return await Broker.SubscribeAsync("browsingContext.navigationCommitted", handler, options).ConfigureAwait(false);
258+
}
259+
250260
public async Task<Subscription> OnContextCreatedAsync(Func<BrowsingContextInfo, Task> handler, BrowsingContextsSubscriptionOptions? options = null)
251261
{
252262
return await Broker.SubscribeAsync("browsingContext.contextCreated", handler, options).ConfigureAwait(false);

0 commit comments

Comments
 (0)