Code review

Author: nex3

pkg/sass-parser/CHANGELOG.md

@@ -1,6 +1,6 @@
 ## 0.4.9
 
-* No user-visible changes.
+* Add support for parsing the `@if` and `@else` rules.
 
 ## 0.4.8
 

pkg/sass-parser/lib/src/statement/else-rule.test.ts

@@ -17,7 +17,7 @@ describe('an @else rule', () => {
         it('has no expression', () =>
           expect(node.elseCondition).toBeUndefined());
 
-        it('has matching params', () => expect(node.params).toBe(''));
+        it('has empty params', () => expect(node.params).toBe(''));
 
         it('has empty nodes', () => expect(node.nodes).toEqual([]));
       });
@@ -86,7 +86,7 @@ describe('an @else rule', () => {
         it('has an expression', () =>
           expect(node.elseCondition).toBeUndefined());
 
-        it('has matching params', () => expect(node.params).toBe(''));
+        it('has empty params', () => expect(node.params).toBe(''));
 
         it('has a child node', () => {
           expect(node.nodes).toHaveLength(1);

pkg/sass-parser/lib/src/statement/index.ts

@@ -208,11 +208,14 @@ const visitor = sassInternal.createStatementVisitor<Statement | Statement[]>({
   visitFunctionRule: inner => new FunctionRule(undefined, inner),
   visitIfRule: inner => {
     const rules: Statement[] = [new IfRule(undefined, inner)];
+
+    // Skip `inner.clauses[0]` because it's already used by `new IfRule()`.
     for (let i = 1; i < inner.clauses.length; i++) {
       rules.push(new ElseRule(undefined, inner, inner.clauses[i]));
     }
-    if (inner.lastClause)
+    if (inner.lastClause) {
       rules.push(new ElseRule(undefined, inner, inner.lastClause));
+    }
     return rules;
   },
   visitIncludeRule: inner => new IncludeRule(undefined, inner),