Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Commit 98e75b3

Browse files
authored
feat: Node 18 and 19 support and drop Node 17 (#3257)
Fixes #3251
1 parent e9bb866 commit 98e75b3

File tree

7 files changed

+25
-18
lines changed

7 files changed

+25
-18
lines changed

Diff for: .github/workflows/alpine.yml

+3-2
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,10 @@ jobs:
1616
matrix:
1717
node:
1818
- 14
19-
# Node 16 and 17 are perma-red for the tests right now
19+
# Node 16+ are perma-red for the tests right now
2020
# - 16
21-
# - 17
21+
# - 18
22+
# - 19
2223

2324
steps:
2425
- name: Install Alpine build tools

Diff for: .github/workflows/linux.yml

+7-3
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
node:
1717
- 14
1818
- 16
19-
- 17
19+
- 18
2020

2121
include:
2222
- node: 14
@@ -27,10 +27,14 @@ jobs:
2727
gcc: "gcc-8"
2828
gpp: "g++-8"
2929
os: ubuntu-18.04
30-
- node: 17
30+
- node: 18
3131
gcc: "gcc-8"
3232
gpp: "g++-8"
33-
os: ubuntu-18.04
33+
os: ubuntu-20.04
34+
- node: 19
35+
gcc: "gcc-8"
36+
gpp: "g++-8"
37+
os: ubuntu-20.04
3438

3539

3640
steps:

Diff for: .github/workflows/macos.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ jobs:
1616
node:
1717
- 14
1818
- 16
19-
- 17
19+
- 18
20+
- 19
2021

2122
steps:
2223
- uses: actions/checkout@v3

Diff for: .github/workflows/windows.yml

+3-10
Original file line numberDiff line numberDiff line change
@@ -8,28 +8,21 @@ on:
88

99
jobs:
1010
build:
11-
runs-on: ${{ matrix.os }}
11+
runs-on: windows-2019
1212

1313
strategy:
1414
fail-fast: false
1515
matrix:
1616
node:
1717
- 14
1818
- 16
19-
- 17
19+
- 18
20+
- 19
2021

2122
architecture:
2223
- x64
2324
- x86
2425

25-
include:
26-
- node: 14
27-
os: windows-2019
28-
- node: 16
29-
os: windows-2019
30-
- node: 17
31-
os: windows-2019
32-
3326
steps:
3427
- uses: actions/checkout@v3
3528

Diff for: README.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@ Below is a quick guide for minimum and maximum supported versions of node-sass:
1717

1818
NodeJS | Supported node-sass version | Node Module
1919
--------|-----------------------------|------------
20-
Node 17 | 7.0+ | 102
20+
Node 19 | 8.0+ | 111
21+
Node 18 | 8.0+ | 108
22+
Node 17 | 7.0+, <8.0 | 102
2123
Node 16 | 6.0+ | 93
2224
Node 15 | 5.0+, <7.0 | 88
2325
Node 14 | 4.14+ | 83

Diff for: appveyor.yml

+5-1
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,13 @@
3939
- nodejs_version: 16
4040
GYP_MSVS_VERSION: 2019
4141
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
42-
- nodejs_version: 17
42+
- nodejs_version: 18
4343
GYP_MSVS_VERSION: 2019
4444
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
45+
- nodejs_version: 19
46+
GYP_MSVS_VERSION: 2019
47+
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
48+
4549

4650
install:
4751
# https://www.appveyor.com/docs/lang/nodejs-iojs/#installing-any-version-of-nodejs-or-iojs

Diff for: lib/extensions.js

+2
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,8 @@ function getHumanNodeVersion(abi) {
8282
case 88: return 'Node.js 15.x';
8383
case 93: return 'Node.js 16.x';
8484
case 102: return 'Node.js 17.x';
85+
case 108: return 'Node.js 18.x';
86+
case 111: return 'Node.js 19.x';
8587
default: return false;
8688
}
8789
}

0 commit comments

Comments
 (0)