Skip to content

Commit 380a9dd

Browse files
authored
Fix test_cubegeom_pre_relocatable (emscripten-core#21240)
This test was broken by emscripten-core#21103 but when unnoticed because we run our browser tests with swiftshader enabled, which skips this test.
1 parent 8747ab0 commit 380a9dd

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

test/test_browser.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2085,7 +2085,10 @@ def test_cubegeom_pre_regal(self):
20852085
@requires_graphics_hardware
20862086
@no_swiftshader
20872087
def test_cubegeom_pre_relocatable(self):
2088-
self.btest('third_party/cubegeom/cubegeom_pre.c', reference='third_party/cubegeom/cubegeom_pre.png', args=['-sLEGACY_GL_EMULATION', '-lGL', '-lSDL', '-sRELOCATABLE'])
2088+
# RELOCATABLE needs to be set via `set_setting` so that it will also apply when
2089+
# building `browser_reporting.c`
2090+
self.set_setting('RELOCATABLE')
2091+
self.btest('third_party/cubegeom/cubegeom_pre.c', reference='third_party/cubegeom/cubegeom_pre.png', args=['-sLEGACY_GL_EMULATION', '-lGL', '-lSDL'])
20892092

20902093
@requires_graphics_hardware
20912094
@no_swiftshader

0 commit comments

Comments
 (0)