Skip to content

Commit f23c8d4

Browse files
committed
Cleanup test_modularize_init_error. NFC
- Use browser_reporting.js directly. - Delete redundant unhandledrejection handler. browser_reporting handles this already.
1 parent ca9ff60 commit f23c8d4

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

test/test_browser.py

+6-9
Original file line numberDiff line numberDiff line change
@@ -3342,9 +3342,10 @@ def test_modularize(self, opts):
33423342
self.run_browser('a.html', '/report_result?0')
33433343

33443344
def test_modularize_network_error(self):
3345-
browser_reporting_js_path = test_file('browser_reporting.js')
3346-
self.compile_btest('browser_test_hello_world.c', ['-sMODULARIZE', '-sEXPORT_NAME="createModule"', '--extern-pre-js', browser_reporting_js_path], reporting=Reporting.NONE)
3345+
self.compile_btest('browser_test_hello_world.c', ['-sMODULARIZE', '-sEXPORT_NAME=createModule'], reporting=Reporting.NONE)
3346+
shutil.copy(test_file('browser_reporting.js'), '.')
33473347
create_file('a.html', '''
3348+
<script src="browser_reporting.js"></script>
33483349
<script src="a.out.js"></script>
33493350
<script>
33503351
createModule()
@@ -3361,16 +3362,12 @@ def test_modularize_network_error(self):
33613362
self.run_browser('a.html', '/report_result?Aborted(both async and sync fetching of the wasm failed)')
33623363

33633364
def test_modularize_init_error(self):
3364-
browser_reporting_js_path = test_file('browser_reporting.js')
3365-
self.compile_btest('browser/test_modularize_init_error.cpp', ['-sMODULARIZE', '-sEXPORT_NAME="createModule"', '--extern-pre-js', browser_reporting_js_path], reporting=Reporting.NONE)
3365+
self.compile_btest('browser/test_modularize_init_error.cpp', ['-sMODULARIZE', '-sEXPORT_NAME=createModule'], reporting=Reporting.NONE)
3366+
shutil.copy(test_file('browser_reporting.js'), '.')
33663367
create_file('a.html', '''
3368+
<script src="browser_reporting.js"></script>
33673369
<script src="a.out.js"></script>
33683370
<script>
3369-
if (typeof window === 'object') {
3370-
window.addEventListener('unhandledrejection', function(event) {
3371-
reportResultToServer("Unhandled promise rejection: " + event.reason.message);
3372-
});
3373-
}
33743371
createModule()
33753372
.then(() => {
33763373
reportResultToServer("Module creation succeeded when it should have failed");

0 commit comments

Comments
 (0)