Skip to content

Using relative paths rather than absolute #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxsam4 opened this issue Oct 10, 2018 · 2 comments
Closed

Using relative paths rather than absolute #300

maxsam4 opened this issue Oct 10, 2018 · 2 comments

Comments

@maxsam4
Copy link
Contributor

maxsam4 commented Oct 10, 2018

Currently, the path included in the event that is added by the instrumenter is an absolute path which can be huge.

Our instrumented contracts at https://github.com/PolymathNetwork/polymath-core have now become so big due to the absolute paths that they are failing to compile. They instrument and compile just fine if I move the project folder nearer to the root of the system as the absolute path becomes shorter.

I am not sure why absolute paths are currently being used over relative paths. I can provide a set of instrumented contracts that are failing to compile due to huge absolute path, if required.

Update: I have created a PR to fix this.

@cgewecke
Copy link
Member

cgewecke commented Jul 15, 2019

In work planned for 0.7.0 (see #346) we will use an in-process memory to track file locations. Instrumentation will consist of a hash to those values.

Implementation detail: nyc issue 110: Relative paths in the coverage file are in violation of istanbul spec

@cgewecke
Copy link
Member

Published w/ 0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants