Skip to content

Bump solidity-parser to 0.9.1 #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
junderw opened this issue Nov 19, 2020 · 8 comments
Closed

Bump solidity-parser to 0.9.1 #575

junderw opened this issue Nov 19, 2020 · 8 comments

Comments

@junderw
Copy link
Contributor

junderw commented Nov 19, 2020

Currently using separated hex'ffff' hex'ffff' hex literals causes solidity-coverage to break.

@cgewecke
Copy link
Member

Ok thanks @junderw.

@cgewecke
Copy link
Member

@junderw

The parser has been receiving quite frequent updates that don't automatically propagate, e.g from 0.7.x to 0.8.x. because of the way npm interprets 0-series caret ranges

If you need to use improvements there immediately and you're open to installing with yarn, you might be interested in yarn's selective-version-resolutions feature which lets you coerce sub-dependencies of a module to whatever version you prefer.

@junderw
Copy link
Contributor Author

junderw commented Nov 19, 2020

perhaps 0.9.x would work?

@junderw
Copy link
Contributor Author

junderw commented Nov 19, 2020

looks like using ^0.9.x will allow anything <0.10.0

would using that for a dep be ok for this library.

@cgewecke
Copy link
Member

cgewecke commented Nov 19, 2020

Yes it would work - I just mean this project doesn't publish at the same cadence and we'd need to re-publish here to update that dependency. I am waiting for bugs to be reported about the Hardhat plugin and probably will not cut another release until those are reported / resolved, maybe next week.

I think the linter may be much more sensitive to what constitutes a breaking change in the parser than this tool is (hence the frequency of what are de-facto major version releases there, e.g. ~1 per month).

@cgewecke
Copy link
Member

cgewecke commented Dec 3, 2020

Update: 0.9.x is using a new antlr4 runtime which requires Node >= 14. (LTS as of late October)

To not break people whose CI still running on 12, this dep update will need to go in the next minor version bump here (0.8.x) which is scheduled for end of December.

@cgewecke
Copy link
Member

cgewecke commented Jan 15, 2021

Sorry for the delay fixing this...0.7.14 includes the latest solidity-parser/parser: v0.11.0

Should include support for everything through solc v0.8.x

@junderw
Copy link
Contributor Author

junderw commented Jan 15, 2021

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants