-
Notifications
You must be signed in to change notification settings - Fork 19
Add groupMapReduce to Iterator #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
not fixable in 2.13. should be transferred to scala/scala-library-next for sooner fix |
everyone okay with this change? (👍 in favour, 👎 against) |
it has been about 2 weeks, with moderate explicit support and no dissent. if there is no dissent by this coming Sunday (2020-12-06), or if we get a couple lightbend approvals before then (without any dissenting opinions), I will consider this proposal accepted. obviously, we can still come back to it at any later point before release and change things if we decide to |
Note that I think we should probably hold off on actually merging any PRs here until we have some kind of signoff process. I made a ticket on it: #52 |
as context for the fact that I merged this anyway, this comment by Seth in Gitter; I think this is a fairly uncontroversial change, as it just moves the method up the collections hierarchy |
Yeah, that's fine. We can handle things on a case by case basis until we have something written down. |
Currently
groupMapReduce
is defined inIterableOps
so it's not available forIterator
, but it easily could be because it doesn't require building an inner collection of the collection type, unlikegroupBy
andgroupMap
. ThusgroupMapReduce
would be hoisted toIterableOnceOps
instead and be a consuming operation on the iterator.I suppose the current workaround would be to use
to(LazyList)
on an iterator and usegroupMapReduce
on that.The text was updated successfully, but these errors were encountered: