Skip to content

add Scala 2.13.0-Mx to crossScalaVersions #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SethTisue opened this issue Apr 21, 2017 · 5 comments
Closed

add Scala 2.13.0-Mx to crossScalaVersions #142

SethTisue opened this issue Apr 21, 2017 · 5 comments

Comments

@SethTisue
Copy link
Member

for x=1, currently

because of the circular dependency between scalac and scala-xml, the Scala release process also publishes scala-xml, so 1.0.6 is already published for 2.13.0-M1

so, this isn't pressing.

nonetheless, it would be good to have 2.13.0-M1 in crossScalaVersions, so that if a new scala-xml version is released, it gets published for that Scala version

@ashawley
Copy link
Member

Ok, then we'll need definitely need to bump a la #141 to support a 2.13. Otherwise, mima will fail when building because it won't have a previous 2.13 build (unless somebody publishes a 1.0.5 build with 2.13). In this case, the circular dependency helps rather than hurts in this way.

@SethTisue
Copy link
Member Author

Oh haha you already thought through what I just got done writing on the other ticket.

@ashawley
Copy link
Member

Hilarious! Well, hopefully we came around to the same conclusions.

@ashawley
Copy link
Member

Looks like @lrytz is working on this in #145

@ashawley
Copy link
Member

ashawley commented Jun 8, 2017

The sbt-scala-modules plugin uses scalaVersionsByJvm to set `crossScalaVersions in the build, and it's done so for 2.13.0-M1

@ashawley ashawley closed this as completed Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants