Skip to content

Commit 602f659

Browse files
nicolasstuckiprolativ
authored andcommitted
Remove stdlib213 from community build tests
This test exists for historical reasons. Now we compile the Scala 2 library in the `scala2-library-bootstrapped` project. This one checks that it compiles (with `-Ycheck:all`) and is used to package the TASTy files in the `scala2-library-tasty` project. Furthermore, now there is a `scala/scala` test that checks that the library can be compiled with Scala 3. This test is fundamentally broken but we have not noticed it because we do not use `-Ycheck:all`. The reason is that when we compile `scala.Predef` we get a conflict with `scala.runtime.stdLibPatches.Predef` when we patch the symbols. This also surfaced in #18738. [Cherry-picked 8c6f4c7]
1 parent e2cacca commit 602f659

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

Diff for: community-build/src/scala/dotty/communitybuild/projects.scala

-9
Original file line numberDiff line numberDiff line change
@@ -358,14 +358,6 @@ object projects:
358358
// sbtDocCommand = "dotty-community-build/doc"
359359
)
360360

361-
lazy val stdLib213 = SbtCommunityProject(
362-
project = "stdLib213",
363-
extraSbtArgs = List("-Dscala.build.compileWithDotty=true"),
364-
sbtTestCommand = """set Global / fatalWarnings := false; library/compile""",
365-
sbtPublishCommand = """set Global / fatalWarnings := false; set library/Compile/packageDoc/publishArtifact := false; library/publishLocal""",
366-
// sbtDocCommand = "library/doc" // Does no compile? No idea :/
367-
)
368-
369361
lazy val shapeless3 = SbtCommunityProject(
370362
project = "shapeless-3",
371363
sbtTestCommand = List(
@@ -796,7 +788,6 @@ def allProjects = List(
796788
projects.scalaPB,
797789
projects.minitest,
798790
projects.fastparse,
799-
projects.stdLib213,
800791
projects.shapeless3,
801792
projects.xmlInterpolator,
802793
projects.effpi,

Diff for: community-build/test/scala/dotty/communitybuild/CommunityBuildTest.scala

-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ class CommunityBuildTestC:
9595
@Test def sourcecode = projects.sourcecode.run()
9696
@Test def specs2 = projects.specs2.run()
9797

98-
@Test def stdLib213 = projects.stdLib213.run()
9998
@Test def ujson = projects.ujson.run()
10099
@Test def upickle = projects.upickle.run()
101100
@Test def utest = projects.utest.run()

0 commit comments

Comments
 (0)