Skip to content

Commit 8c22acb

Browse files
KacperFKorbanWojciechMazur
authored andcommitted
Bump Inkuire version to fix it for the new Scala versions (#21611)
It seems like Inkuire depended on the way some type lambdas were encoded in TASTy which caused it to falsely reject a ton of valid functions. This update also includes a slight change to the ordering heuristic, so that more complicated names of functions are shown lower in the lost and synthetic names are shown last. Inkuire changes: - `1.0.0-M8` https://github.com/VirtusLab/Inkuire/releases/tag/v1.0.0-M8 - `1.0.0-M9` https://github.com/VirtusLab/Inkuire/releases/tag/v1.0.0-M9 [Cherry-picked 8068239]
1 parent fbeda00 commit 8c22acb

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

Diff for: project/DocumentationWebsite.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ object DocumentationWebsite {
4343
import _root_.scala.concurrent._
4444
import _root_.scala.concurrent.duration.Duration
4545
import ExecutionContext.Implicits.global
46-
val inkuireVersion = "v1.0.0-M7"
46+
val inkuireVersion = "v1.0.0-M9"
4747
val inkuireLink = s"https://github.com/VirtusLab/Inkuire/releases/download/$inkuireVersion/inkuire.js"
4848
val inkuireDestinationFile = baseDest / "dotty_res" / "scripts" / "inkuire.js"
4949
sbt.IO.touch(inkuireDestinationFile)

Diff for: scaladoc/src/dotty/tools/scaladoc/tasty/InkuireSupport.scala

+4-4
Original file line numberDiff line numberDiff line change
@@ -184,10 +184,10 @@ trait InkuireSupport(using DocContext) extends Resources:
184184
else ownerNameChain(sym.owner) :+ sym.normalizedName
185185

186186
private def viableSymbol(s: Symbol): Boolean =
187-
!s.flags.is(Flags.Private) &&
188-
!s.flags.is(Flags.Protected) &&
189-
!s.flags.is(Flags.Override) &&
190-
!s.flags.is(Flags.Synthetic)
187+
!s.flags.is(Flags.Private) &&
188+
!s.flags.is(Flags.Protected) &&
189+
!s.flags.is(Flags.Override) &&
190+
!s.flags.is(Flags.Synthetic)
191191

192192
private def varName(t: Inkuire.TypeLike): Option[String] = t match {
193193
case tpe: Inkuire.Type => Some(tpe.name.name)

0 commit comments

Comments
 (0)