Let -Wall override -Wunused

Author: Linyxus

Diff for: compiler/src/dotty/tools/dotc/config/ScalaSettings.scala

@@ -203,7 +203,7 @@ private sealed trait WarningSettings:
     def nowarn(using Context) = allOr("nowarn")
 
     // Is any choice set for -Wunused?
-    def any(using Context): Boolean = Wunused.value.nonEmpty
+    def any(using Context): Boolean = Wall.value || Wunused.value.nonEmpty
 
     // overrided by strict-no-implicit-warn
     def imports(using Context) =

Diff for: tests/warn/i18559c.check

@@ -1,4 +1,12 @@
+-- [E198] Unused Symbol Warning: tests/warn/i18559c.scala:4:28 ---------------------------------------------------------
+4 |  import collection.mutable.Set // warn
+  |                            ^^^
+  |                            unused import
 -- [E198] Unused Symbol Warning: tests/warn/i18559c.scala:8:8 ----------------------------------------------------------
 8 |    val x = 1  // warn
   |        ^
   |        unused local definition
+-- [E198] Unused Symbol Warning: tests/warn/i18559c.scala:11:26 --------------------------------------------------------
+11 |  import SomeGivenImports.given // warn
+   |                          ^^^^^
+   |                          unused import

Diff for: tests/warn/i18559c.scala

@@ -1,14 +1,14 @@
 //> using options -Wall -Wunused:locals
-// This test checks that -Wall leaves -Wunused:... untouched if it is already set
+// This test checks that -Wall overrides -Wunused:... if it is already set
 object FooImportUnused:
-  import collection.mutable.Set // not warn
+  import collection.mutable.Set // warn
 
 object FooUnusedLocal:
   def test(): Unit =
     val x = 1  // warn
 
 object FooGivenUnused:
-  import SomeGivenImports.given // not warn
+  import SomeGivenImports.given // warn
 
 object SomeGivenImports:
   given Int = 0