Skip to content

Nightly Dotty workflow of 2024-11-04 failed #21882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions bot opened this issue Nov 4, 2024 · 2 comments · Fixed by #21911
Closed

Nightly Dotty workflow of 2024-11-04 failed #21882

github-actions bot opened this issue Nov 4, 2024 · 2 comments · Fixed by #21911
Assignees
Labels

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

See https://github.com/scala/scala3/actions/runs/11657389191

@Gedochao
Copy link
Contributor

Gedochao commented Nov 4, 2024

Error:  Test dotty.tools.dotc.profile.ChromeTraceTest.traceDurationEvents failed: java.lang.AssertionError: null, took 0.041 sec
Error:      at dotty.tools.dotc.profile.ChromeTraceTest$$anon$3.applyOrElse(ChromeTraceTest.scala:87)
Error:      at dotty.tools.dotc.profile.ChromeTraceTest$$anon$3.applyOrElse(ChromeTraceTest.scala:63)
Error:      at dotty.tools.dotc.profile.ChromeTraceTest.testTraceOutputs(ChromeTraceTest.scala:21)
Error:      at dotty.tools.dotc.profile.ChromeTraceTest.traceDurationEvents(ChromeTraceTest.scala:91)
Error:      ...

...but it seems it's flaky...

Error:  All tests passed after retry, indicating that some tests are flaky.
Error:  This build is configured to reject flaky tests.
Error:  Failed: Total 672, Failed 0, Errors 0, Passed 672, Ignored 8
Error:  (scala3-compiler-bootstrapped / Test / testOnly) sbt.TestsFailedException: Tests unsuccessful
Error:  Total time: 1937 s (32:17), completed Nov 4, 2024 4:46:52 AM

cc @hamzaremmal @WojciechMazur any clue?

@WojciechMazur
Copy link
Contributor

WojciechMazur commented Nov 4, 2024

The traces indicate that assertions for the duration of events were incorrect - operation finished faster then expected. It might be related to Windows specific LockSupport.park implementation. AFAIR it can continue execution a bit earlier then expected. I'll try to improve the tests when I'm back on Wednesday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants