Skip to content

Port ClassfileParser improvements from Scala 2 #6136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smarter opened this issue Mar 21, 2019 · 1 comment · Fixed by #10037
Closed

Port ClassfileParser improvements from Scala 2 #6136

smarter opened this issue Mar 21, 2019 · 1 comment · Fixed by #10037
Assignees
@anatoliykmetyuk
Labels
area:classpath compat:scala2 itype:enhancement

Comments

@smarter
Copy link
Member

smarter commented Mar 21, 2019

Our version of ClassfileParser was copied from Scala 2 a long time ago, since then we've ported some of the improvements made there but not all of them, in particular the recently merged scala/scala#6653 (comment) looks interesting.
@smarter smarter mentioned this issue Mar 21, 2019
Merged
@smarter smarter mentioned this issue Apr 5, 2019
Closed
@anatoliykmetyuk anatoliykmetyuk mentioned this issue Apr 15, 2019
Closed
@anatoliykmetyuk anatoliykmetyuk mentioned this issue Apr 23, 2019
Closed
@anatoliykmetyuk
Copy link
Contributor

After talking to @adriaanm, I opened the scala/scala-dev#625 issue to see if we can address the problem of code sharing in a more generalised way.

@smarter smarter linked a pull request Oct 27, 2020 that will close this issue
Port classfile parsing improvements #10037
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anatoliykmetyuk anatoliykmetyuk

Labels
area:classpath compat:scala2 itype:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Port classfile parsing improvements dotty-staging/dotty
2 participants
@smarter @anatoliykmetyuk