Skip to content

Commit aae17ae

Browse files
author
Quentin Perez
authored
Merge pull request #421 from QuentinPerez/login
fix login
2 parents 54e5d76 + 4c2e1be commit aae17ae

File tree

2 files changed

+22
-3
lines changed

2 files changed

+22
-3
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1203,7 +1203,7 @@ $ scw inspect myserver | jq '.[0].public_ip.address'
12031203

12041204
### master (unreleased)
12051205

1206-
* No entry
1206+
* `scw login` fix CheckCredentials ([418](https://github.com/scaleway/scaleway-cli/issues/418))
12071207

12081208
View full [commits list](https://github.com/scaleway/scaleway-cli/compare/v1.10...master)
12091209

pkg/api/api.go

+21-2
Original file line numberDiff line numberDiff line change
@@ -660,6 +660,11 @@ type ScalewayTokensDefinition struct {
660660
Token ScalewayTokenDefinition `json:"token"`
661661
}
662662

663+
// ScalewayGetTokens represents a list of Scaleway Tokens
664+
type ScalewayGetTokens struct {
665+
Tokens []ScalewayTokenDefinition `json:"tokens"`
666+
}
667+
663668
// ScalewayContainerData represents a Scaleway container data (S3)
664669
type ScalewayContainerData struct {
665670
LastModified string `json:"last_modified"`
@@ -1908,7 +1913,6 @@ func (s *ScalewayAPI) GetTasks() (*[]ScalewayTask, error) {
19081913
// CheckCredentials performs a dummy check to ensure we can contact the API
19091914
func (s *ScalewayAPI) CheckCredentials() error {
19101915
query := url.Values{}
1911-
query.Set("token_id", s.Token)
19121916

19131917
resp, err := s.GetResponsePaginate(AccountAPI, "tokens", query)
19141918
if resp != nil {
@@ -1917,10 +1921,25 @@ func (s *ScalewayAPI) CheckCredentials() error {
19171921
if err != nil {
19181922
return err
19191923
}
1924+
body, err := s.handleHTTPError([]int{http.StatusOK}, resp)
1925+
if err != nil {
1926+
return err
1927+
}
1928+
found := false
1929+
var tokens ScalewayGetTokens
19201930

1921-
if _, err := s.handleHTTPError([]int{http.StatusOK}, resp); err != nil {
1931+
if err = json.Unmarshal(body, &tokens); err != nil {
19221932
return err
19231933
}
1934+
for _, token := range tokens.Tokens {
1935+
if token.ID == s.Token {
1936+
found = true
1937+
break
1938+
}
1939+
}
1940+
if !found {
1941+
return fmt.Errorf("Invalid token %v", s.Token)
1942+
}
19241943
return nil
19251944
}
19261945

0 commit comments

Comments
 (0)