Merge pull request #105 from moul/golint-fixes

Golint fixes

Author: moul

pkg/api/cache.go

@@ -70,6 +70,7 @@ type ScalewayResolverResult struct {
 	RankMatch  int
 }
 
+// ScalewayResolverResults is a list of `ScalewayResolverResult`
 type ScalewayResolverResults []ScalewayResolverResult
 
 func (s ScalewayResolverResults) Len() int {
@@ -191,6 +192,7 @@ func (c *ScalewayCache) Save() error {
 	return nil
 }
 
+// ComputeRankMatch fills `ScalewayResolverResult.RankMatch` with its `fuzzy` score
 func (s *ScalewayResolverResult) ComputeRankMatch(needle string) {
 	s.Needle = needle
 	s.RankMatch = fuzzy.RankMatch(needle, s.Name)

pkg/cli/command.go

@@ -19,6 +19,7 @@ import (
 	"github.com/scaleway/scaleway-cli/pkg/commands"
 )
 
+// Command contains everything needed by the cli main loop to calls the workflow, display help and usage, and the context
 type Command struct {
 	// Exec executes the command
 	Exec func(cmd *Command, args []string)

pkg/cli/commands.go

@@ -4,7 +4,7 @@
 
 // Docker-style commands to manage BareMetal servers
 
-// Package commands contains CLI commands
+// Package cli contains CLI commands
 package cli
 
 // Commands is the list of enabled CLI commands

pkg/commands/command.go

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a MIT-style
 // license that can be found in the LICENSE.md file.
 
-// Golang structs for scw commands
+// Package commands contains the workflows behind each commands of the CLI (run, attach, start, exec, commit, ...)
 package commands
 
 import (

pkg/commands/cp.go

@@ -18,6 +18,7 @@ import (
 	"github.com/scaleway/scaleway-cli/vendor/github.com/docker/docker/pkg/archive"
 )
 
+// CpArgs are arguments passed to `RunCp`
 type CpArgs struct {
 	Gateway     string
 	Source      string
@@ -27,7 +28,7 @@ type CpArgs struct {
 // RunCp is the handler for 'scw cp'
 func RunCp(ctx CommandContext, args CpArgs) error {
 	if strings.Count(args.Source, ":") > 1 || strings.Count(args.Destination, ":") > 1 {
-		return fmt.Errorf("bad usage, see 'scw help cp'.")
+		return fmt.Errorf("bad usage, see 'scw help cp'")
 	}
 
 	sourceStream, err := TarFromSource(ctx, args.Source, args.Gateway)

pkg/commands/create.go

@@ -11,6 +11,7 @@ import (
 	"github.com/scaleway/scaleway-cli/pkg/api"
 )
 
+// CreateArgs are arguments passed to `RunCreate`
 type CreateArgs struct {
 	Name       string
 	Bootscript string

pkg/commands/events.go

@@ -11,6 +11,7 @@ import (
 	"github.com/scaleway/scaleway-cli/vendor/github.com/docker/docker/pkg/units"
 )
 
+// EventsArgs are arguments passed to `RunEvents`
 type EventsArgs struct{}
 
 // RunEvents is the handler for 'scw events'

pkg/commands/login.go

@@ -16,6 +16,7 @@ import (
 	"github.com/scaleway/scaleway-cli/pkg/api"
 )
 
+// LoginArgs are arguments passed to `RunLogin`
 type LoginArgs struct {
 	Organization string
 	Token        string

pkg/commands/rename.go

@@ -26,8 +26,9 @@ func RunRename(ctx CommandContext, args RenameArgs) error {
 	err := ctx.API.PatchServer(serverID, server)
 	if err != nil {
 		return fmt.Errorf("cannot rename server: %v", err)
-	} else {
-		ctx.API.Cache.InsertServer(serverID, *server.Name)
 	}
+
+	ctx.API.Cache.InsertServer(serverID, *server.Name)
+
 	return nil
 }

pkg/commands/version.go

@@ -14,7 +14,7 @@ import (
 // VersionArgs are flags for the `RunVersion` function
 type VersionArgs struct{}
 
-// RunVersion is the handler for 'scw version'
+// Version is the handler for 'scw version'
 func Version(ctx CommandContext, args VersionArgs) error {
 	fmt.Fprintf(ctx.Stdout, "Client version: %s\n", scwversion.VERSION)
 	fmt.Fprintf(ctx.Stdout, "Go version (client): %s\n", runtime.Version())