Skip to content

Commit 826c22b

Browse files
committed
🐛 <TextLink> Apply noopener, noreferrer to isExternal, not [new-tab]
1 parent aedf9e4 commit 826c22b

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

components/TextLink.vue

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,9 @@ export default Vue.extend({
5454
},
5555
rel(): string | null {
5656
let relArray: string[] = []
57-
// Use rel="external" when relevant
58-
if (this.isExternal) relArray = [...relArray, 'external']
5957
// Prevent leaks via `Window.opener`
60-
if (this.newTab) relArray = [...relArray, 'noopener', 'noreferrer']
58+
if (this.isExternal)
59+
relArray = [...relArray, 'external', 'noopener', 'noreferrer']
6160
// rel list is space-separated
6261
const relString = relArray.join(' ')
6362
// Don't include the attribute if the list is empty

0 commit comments

Comments
 (0)