Skip to content

Commit 1a79e3d

Browse files
authored
ci: restore example builds for Windows/macOS (#1025)
Trying to track down a Windows bug where we can't find the correct library to link to but FindPython can, but only when Interpreter is specified. Signed-off-by: Henry Schreiner <[email protected]>
1 parent c9bf4ce commit 1a79e3d

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

Diff for: .github/workflows/ci.yml

+7-2
Original file line numberDiff line numberDiff line change
@@ -331,9 +331,12 @@ jobs:
331331
- uses: hynek/build-and-inspect-python-package@v2
332332

333333
docs:
334-
name: Docs on ubuntu-latest
335-
runs-on: ubuntu-latest
334+
name: Docs on ${{ matrix.runs-on }}
335+
runs-on: ${{ matrix.runs-on }}
336336
timeout-minutes: 15
337+
strategy:
338+
matrix:
339+
runs-on: [ubuntu-latest, macos-latest, windows-latest]
337340

338341
steps:
339342
- uses: actions/checkout@v4
@@ -348,12 +351,14 @@ jobs:
348351
python-versions: "3.12"
349352

350353
- name: Linkcheck
354+
if: runner.os == 'Linux'
351355
run: nox -s docs -- -b linkcheck
352356

353357
- name: Manpage
354358
run: nox -s docs -- -b man -W
355359

356360
- name: Build docs with warnings as errors
361+
if: runner.os == 'Linux'
357362
run: nox -s docs -- -W
358363

359364
- name: Check examples

Diff for: docs/examples/getting_started/c/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ project(${SKBUILD_PROJECT_NAME} LANGUAGES C)
33

44
find_package(
55
Python
6-
COMPONENTS Interpreter Development.Module
6+
COMPONENTS Development.Module
77
REQUIRED)
88

99
python_add_library(example MODULE example.c WITH_SOABI)

0 commit comments

Comments
 (0)