tests: remove pytest-virtualenv (#125)

This is causing various problems, so remove it.

Signed-off-by: Henry Schreiner <[email protected]>

Author: henryiii

.github/workflows/ci.yml

@@ -90,7 +90,7 @@ jobs:
         run: python3.9 -m pip install .[test]
 
       - name: Test package
-        run: python3.9 -m pytest -ra --showlocals
+        run: python3.9 -m pytest -ra --showlocals -m "not virtualenv"
 
   msys:
     name: Tests on 🐍 3 • msys
@@ -148,7 +148,9 @@ jobs:
         run: python -m pip install .[test]
 
       - name: Test package
-        run: python -m pytest -ra --showlocals -k "not test_setuptools_pep518"
+        run: python -m pytest -ra --showlocals -m "not setuptools"
+        env:
+          SETUPTOOLS_USE_DISTUTILS: "local"
 
   dist:
     name: Distribution build

pyproject.toml

@@ -33,9 +33,9 @@ dynamic = ["version"]
 
 dependencies = [
     "exceptiongroup; python_version<'3.11'",
-    "importlib_resources; python_version<'3.9'",
-    "packaging",  # TODO: set a min version
-    "tomli; python_version<'3.11'",
+    "importlib_resources>=1.3; python_version<'3.9'",
+    "packaging>=20.9",
+    "tomli>=1.1; python_version<'3.11'",
     "typing_extensions >=3.7; python_version<'3.8'",
 ]
 # Note: for building wheels and sdists, there are also additional dependencies
@@ -44,24 +44,23 @@ dependencies = [
 
 [project.optional-dependencies]
 pyproject = [
-    "pyproject_metadata",
-    "distlib",
-    "pathspec",
+    "pyproject-metadata>=0.5",
+    "distlib>=0.3.5",
+    "pathspec>=0.10.1",
 ]
 rich = [
     "rich",
 ]
 test = [
-    "build",
+    "build[virtualenv]",
     "cattrs >=22.2.0",
-    "distlib",
+    "distlib>=0.3.5",
     "importlib_metadata; python_version<'3.8'",
-    "pathspec",
+    "pathspec>=0.10.1",
     "pybind11",
-    "pyproject-metadata",
+    "pyproject-metadata>=0.5",
     "pytest >=7.2",
     "pytest-subprocess",
-    "pytest-virtualenv",
     "rich",
     "setuptools",
     "wheel",
@@ -74,7 +73,6 @@ dev = [
     "cattrs >=22.2.0",
     "pytest >=7.2",
     "pytest-subprocess",
-    "pytest-virtualenv",
     "rich",
 ]
 docs = [

tests/conftest.py

@@ -1,9 +1,14 @@
 from __future__ import annotations
 
-import importlib.util
+import os
+import shutil
 import subprocess
 import sys
+import types
+import warnings
+from collections.abc import Generator
 from pathlib import Path
+from venv import EnvBuilder
 
 if sys.version_info < (3, 8):
     import importlib_metadata as metadata
@@ -63,13 +68,55 @@ def isolated(pep518_wheelhouse: str, monkeypatch: pytest.MonkeyPatch) -> None:
     monkeypatch.setenv("PIP_NO_INDEX", "true")
 
 
-has_pyvenv = importlib.util.find_spec("pytest_virtualenv") is not None
+class VEnv(EnvBuilder):
+    executable: Path
+    env_dir: Path
+
+    def __init__(self, env_dir: str) -> None:
+        super().__init__(with_pip=True)
+        # This warning is mistakenly generated by CPython 3.11.0
+        # https://github.com/python/cpython/pull/98743
+        with warnings.catch_warnings():
+            if sys.version_info[:3] == (3, 11, 0):
+                warnings.filterwarnings(
+                    "ignore",
+                    "check_home argument is deprecated and ignored.",
+                    DeprecationWarning,
+                )
+            self.create(env_dir)
+
+    def ensure_directories(
+        self, env_dir: str | bytes | os.PathLike[str] | os.PathLike[bytes]
+    ) -> types.SimpleNamespace:
+        context = super().ensure_directories(env_dir)
+        # Store the path to the venv Python interpreter.
+        # See https://github.com/mesonbuild/meson-python/blob/8a180be7b4abd7e1939a63d5d59f63197ee27cc7/tests/conftest.py#LL79
+        self.executable = Path(context.env_exe)
+        self.env_dir = Path(context.env_dir)
+        return context
+
+    def run(self, expression: str, *, capture: bool = True) -> str:
+        assert capture, "Always capture for now"
+        env = os.environ.copy()
+        env["PATH"] = f"{self.executable.parent}{os.pathsep}{env['PATH']}"
+        env["VIRTUAL_ENV"] = str(self.env_dir)
+        return subprocess.run(
+            expression,
+            check=True,
+            capture_output=capture,
+            text=True,
+            shell=True,
+            env=env,
+        ).stdout.strip()
 
-if not has_pyvenv:
 
-    @pytest.fixture
-    def virtualenv() -> None:
-        pytest.skip("pytest-virtualenv not available")
+@pytest.fixture
+def virtualenv(tmp_path: Path) -> Generator[VEnv, None, None]:
+    path = tmp_path / "venv"
+    try:
+        yield VEnv(str(path))
+    finally:
+        shutil.rmtree(path)
 
 
 def pytest_collection_modifyitems(items: list[pytest.Item]) -> None: