Skip to content

Commit beea6ea

Browse files
authored
docs: fix incorrect name (PYBIND11_NEWPYTHON) (#1021)
See mlc-ai/xgrammar#249. Signed-off-by: Henry Schreiner <[email protected]>
1 parent 7073e8a commit beea6ea

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Diff for: docs/examples/getting_started/pybind11/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
cmake_minimum_required(VERSION 3.15...3.26)
22
project(${SKBUILD_PROJECT_NAME} LANGUAGES CXX)
33

4-
set(PYBIND11_NEWPYTHON ON)
4+
set(PYBIND11_FINDPYTHON ON)
55
find_package(pybind11 CONFIG REQUIRED)
66

77
pybind11_add_module(example example.cpp)

Diff for: docs/guide/getting_started.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ CMake from searching for both `C` and `CXX` compilers (the default).
268268
269269
If you place find Python first, pybind11 will respect it instead of the classic
270270
FindPythonInterp/FindPythonLibs mechanisms, which work, but are not as modern.
271-
Here we set `PYBIND11_NEWPYTHON` to `ON` instead of doing the find Python
271+
Here we set `PYBIND11_FINDPYTHON` to `ON` instead of doing the find Python
272272
ourselves. Pybind11 places its config file such that CMake can find it from
273273
site-packages.
274274

0 commit comments

Comments
 (0)