-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[RFC] Refactor ratio
#411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
@amueller @chkoar @jorisvandenbossche |
I don't really know where and how this is used to give feedback, I think. |
are we talking about this ratio? |
yep |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ratio
is still a bit of a weird parameters. Here is a proposal for further development:float
asratio
which is a valid parameter withbinary
target.'all'
in over-sampling should be changed to'not majority'
. This is currently doing the same process but this is weird for the user.ratio
type.str
should be accepted butdict
should be replaced by alist
since we cannot select how many sample to select. Alsofloat
would not be accepted for the exact same reason.ratio
should also be renamed. My proposalsampling_target
?The text was updated successfully, but these errors were encountered: