Skip to content

Commit d3473d8

Browse files
committed
split installation test out from where we use py310 syntax
1 parent b611396 commit d3473d8

File tree

3 files changed

+17
-15
lines changed

3 files changed

+17
-15
lines changed

.github/workflows/main.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,4 @@ jobs:
4242
run: pip install -r tests/requirements.txt
4343

4444
- name: Test valid numpy installed
45-
run: pytest -k test_valid_numpy_is_installed
45+
run: pytest tests/test_installation.py -k test_valid_numpy_is_installed

tests/test_dependencies.py

-14
Original file line numberDiff line numberDiff line change
@@ -111,17 +111,3 @@ def test_has_at_most_one_pinned_dependency(
111111
assert (
112112
len(filtered_requirements) == int(expect_pin)
113113
), f"{log_msg}.\n{pprint.pformat(environment)}"
114-
115-
116-
def test_valid_numpy_is_installed(cfg_requirements):
117-
filtered_requirements = []
118-
for req in cfg_requirements:
119-
if req.marker.evaluate():
120-
filtered_requirements.append(req)
121-
122-
assert (len(filtered_requirements) == 1), "Expected exactly one pin."
123-
124-
item, = filtered_requirements[0].specifier
125-
126-
import numpy
127-
assert item.version == numpy.__version__

tests/test_installation.py

+16
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
"""Test that version that gets installed (where we can run CI)
2+
matches the expectation defined in setup.cfg"""
3+
4+
5+
def test_valid_numpy_is_installed(cfg_requirements):
6+
filtered_requirements = []
7+
for req in cfg_requirements:
8+
if req.marker.evaluate():
9+
filtered_requirements.append(req)
10+
11+
assert (len(filtered_requirements) == 1), "Expected exactly one pin."
12+
13+
item, = filtered_requirements[0].specifier
14+
15+
import numpy
16+
assert item.version == numpy.__version__

0 commit comments

Comments
 (0)