Skip to content

Commit 84943a1

Browse files
FaramosCZphracek
authored andcommitted
[syntax enhancement] [environment variable addition] MYSQL_VERSION rework
- utilize the ${MYSQL_VERSION} variable through the containerfile - replace all ${VERSION} with ${MYSQL_VERSION} - introduce ${MYSQL_SHORT_VERSION} environment variable - utilize the ${MYSQL_SHORT_VERSION} variable through the containerfile - move all DB version variables together Removal of seemingly redundant ${VERSION} variable was discussed. Great caution should be employed when removing existing environment variables, as users can depend on them. ${VERSION} is currently kept for the compatibility purposes Change of ${MYSQL_VERSION} to ${MARIADB_VERSION} variable was discussed. Convincing positives not found at this moment. Might reconsider later. - note: ${MYSQL_VERSION} is also used in scripts outside of the containerfile - note: in case of removal of ${MYSQL_VERSION}, caution is advised as described above. WARNING: this introduces the ${VERSION} environmental variable to the RHEL 9 and C9S variants !
1 parent a528869 commit 84943a1

7 files changed

+78
-66
lines changed

10.11/Dockerfile.c10s

+11-10
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,13 @@ FROM quay.io/sclorg/s2i-core-c10s:c10s
1111
# * $MYSQL_ROOT_PASSWORD (Optional) - Password for the 'root' MySQL account
1212

1313
ENV MYSQL_VERSION=10.11 \
14+
MYSQL_SHORT_VERSION=1011 \
15+
VERSION=${MYSQL_VERSION} \
1416
APP_DATA=/opt/app-root/src \
1517
HOME=/var/lib/mysql \
1618
NAME=mariadb \
17-
VERSION=10.11 \
1819
ARCH=x86_64 \
19-
SUMMARY="MariaDB 10.11 SQL database server" \
20+
SUMMARY="MariaDB ${MYSQL_VERSION} SQL database server" \
2021
DESCRIPTION="MariaDB is a multi-user, multi-threaded SQL database server. The container \
2122
image provides a containerized packaging of the MariaDB mysqld daemon and client application. \
2223
The mysqld server daemon accepts connections from clients and provides access to content from \
@@ -25,13 +26,13 @@ MariaDB databases on behalf of the clients."
2526
LABEL summary="${SUMMARY}" \
2627
description="${DESCRIPTION}" \
2728
io.k8s.description="${DESCRIPTION}" \
28-
io.k8s.display-name="MariaDB ${VERSION}" \
29+
io.k8s.display-name="MariaDB ${MYSQL_VERSION}" \
2930
io.openshift.expose-services="3306:mysql" \
30-
io.openshift.tags="database,mysql,${NAME},${NAME}1011,${NAME}-1011" \
31-
com.redhat.component="${NAME}-1011-container" \
32-
name="sclorg/${NAME}-1011-c10s" \
31+
io.openshift.tags="database,mysql,${NAME},${NAME}${MYSQL_SHORT_VERSION},${NAME}-${MYSQL_SHORT_VERSION}" \
32+
com.redhat.component="${NAME}-${MYSQL_SHORT_VERSION}-container" \
33+
name="sclorg/${NAME}-${MYSQL_SHORT_VERSION}-c10s" \
3334
version="1" \
34-
usage="podman run -d -e MYSQL_USER=user -e MYSQL_PASSWORD=pass -e MYSQL_DATABASE=db -p 3306:3306 quay.io/sclorg/${NAME}-1011-c10s" \
35+
usage="podman run -d -e MYSQL_USER=user -e MYSQL_PASSWORD=pass -e MYSQL_DATABASE=db -p 3306:3306 quay.io/sclorg/${NAME}-${MYSQL_SHORT_VERSION}-c10s" \
3536
maintainer="SoftwareCollections.org <[email protected]>"
3637

3738
EXPOSE 3306
@@ -51,9 +52,9 @@ RUN INSTALL_PKGS="policycoreutils rsync tar xz gettext hostname bind-utils groff
5152
ENV CONTAINER_SCRIPTS_PATH=/usr/share/container-scripts/mysql \
5253
MYSQL_PREFIX=/usr
5354

54-
COPY 10.11/root-common /
55-
COPY 10.11/s2i-common/bin/ ${STI_SCRIPTS_PATH}
56-
COPY 10.11/root /
55+
COPY ${MYSQL_VERSION}/root-common /
56+
COPY ${MYSQL_VERSION}/s2i-common/bin/ ${STI_SCRIPTS_PATH}
57+
COPY ${MYSQL_VERSION}/root /
5758

5859
# Hard links are not supported in Testing Farm approach during sync to guest
5960
# operation system. Therefore tests are failing on error

10.11/Dockerfile.c9s

+11-9
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,12 @@ FROM quay.io/sclorg/s2i-core-c9s:c9s
1111
# * $MYSQL_ROOT_PASSWORD (Optional) - Password for the 'root' MySQL account
1212

1313
ENV MYSQL_VERSION=10.11 \
14+
MYSQL_SHORT_VERSION=1011 \
15+
VERSION=${MYSQL_VERSION} \
1416
APP_DATA=/opt/app-root/src \
1517
HOME=/var/lib/mysql \
1618
NAME=mariadb \
17-
SUMMARY="MariaDB 10.11 SQL database server" \
19+
SUMMARY="MariaDB ${MYSQL_VERSION} SQL database server" \
1820
DESCRIPTION="MariaDB is a multi-user, multi-threaded SQL database server. The container \
1921
image provides a containerized packaging of the MariaDB mysqld daemon and client application. \
2022
The mysqld server daemon accepts connections from clients and provides access to content from \
@@ -23,13 +25,13 @@ MariaDB databases on behalf of the clients."
2325
LABEL summary="${SUMMARY}" \
2426
description="${DESCRIPTION}" \
2527
io.k8s.description="${DESCRIPTION}" \
26-
io.k8s.display-name="MariaDB 10.11" \
28+
io.k8s.display-name="MariaDB ${MYSQL_VERSION}" \
2729
io.openshift.expose-services="3306:mysql" \
28-
io.openshift.tags="database,mysql,${NAME},${NAME}1011,${NAME}-1011" \
29-
com.redhat.component="${NAME}-1011-container" \
30-
name="sclorg/${NAME}-1011-c9s" \
30+
io.openshift.tags="database,mysql,${NAME},${NAME}${MYSQL_SHORT_VERSION},${NAME}-${MYSQL_SHORT_VERSION}" \
31+
com.redhat.component="${NAME}-${MYSQL_SHORT_VERSION}-container" \
32+
name="sclorg/${NAME}-${MYSQL_SHORT_VERSION}-c9s" \
3133
version="1" \
32-
usage="podman run -d -e MYSQL_USER=user -e MYSQL_PASSWORD=pass -e MYSQL_DATABASE=db -p 3306:3306 quay.io/sclorg/${NAME}-1011-c9s" \
34+
usage="podman run -d -e MYSQL_USER=user -e MYSQL_PASSWORD=pass -e MYSQL_DATABASE=db -p 3306:3306 quay.io/sclorg/${NAME}-${MYSQL_SHORT_VERSION}-c9s" \
3335
maintainer="SoftwareCollections.org <[email protected]>"
3436

3537
EXPOSE 3306
@@ -50,9 +52,9 @@ RUN yum -y module enable ${NAME}:${MYSQL_VERSION} && \
5052
ENV CONTAINER_SCRIPTS_PATH=/usr/share/container-scripts/mysql \
5153
MYSQL_PREFIX=/usr
5254

53-
COPY 10.11/root-common /
54-
COPY 10.11/s2i-common/bin/ ${STI_SCRIPTS_PATH}
55-
COPY 10.11/root /
55+
COPY ${MYSQL_VERSION}/root-common /
56+
COPY ${MYSQL_VERSION}/s2i-common/bin/ ${STI_SCRIPTS_PATH}
57+
COPY ${MYSQL_VERSION}/root /
5658

5759
# Hard links are not supported in Testing Farm approach during sync to guest
5860
# operation system. Therefore tests are failing on error

10.11/Dockerfile.fedora

+11-10
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,13 @@ FROM quay.io/fedora/s2i-core:40
1111
# * $MYSQL_ROOT_PASSWORD (Optional) - Password for the 'root' MySQL account
1212

1313
ENV MYSQL_VERSION=10.11 \
14+
MYSQL_SHORT_VERSION=1011 \
15+
VERSION=${MYSQL_VERSION} \
1416
APP_DATA=/opt/app-root/src \
1517
HOME=/var/lib/mysql \
1618
NAME=mariadb \
17-
VERSION=10.11 \
1819
ARCH=x86_64 \
19-
SUMMARY="MariaDB 10.11 SQL database server" \
20+
SUMMARY="MariaDB ${MYSQL_VERSION} SQL database server" \
2021
DESCRIPTION="MariaDB is a multi-user, multi-threaded SQL database server. The container \
2122
image provides a containerized packaging of the MariaDB mysqld daemon and client application. \
2223
The mysqld server daemon accepts connections from clients and provides access to content from \
@@ -25,13 +26,13 @@ MariaDB databases on behalf of the clients."
2526
LABEL summary="${SUMMARY}" \
2627
description="${DESCRIPTION}" \
2728
io.k8s.description="${DESCRIPTION}" \
28-
io.k8s.display-name="MariaDB ${VERSION}" \
29+
io.k8s.display-name="MariaDB ${MYSQL_VERSION}" \
2930
io.openshift.expose-services="3306:mysql" \
30-
io.openshift.tags="database,mysql,${NAME},${NAME}1011,${NAME}-1011" \
31+
io.openshift.tags="database,mysql,${NAME},${NAME}${MYSQL_SHORT_VERSION},${NAME}-${MYSQL_SHORT_VERSION}" \
3132
com.redhat.component="${NAME}" \
32-
name="fedora/${NAME}-1011" \
33-
version="${VERSION}" \
34-
usage="podman run -d -e MYSQL_USER=user -e MYSQL_PASSWORD=pass -e MYSQL_DATABASE=db -p 3306:3306 quay.io/fedora/${NAME}-1011" \
33+
name="fedora/${NAME}-${MYSQL_SHORT_VERSION}" \
34+
version="${MYSQL_VERSION}" \
35+
usage="podman run -d -e MYSQL_USER=user -e MYSQL_PASSWORD=pass -e MYSQL_DATABASE=db -p 3306:3306 quay.io/fedora/${NAME}-${MYSQL_SHORT_VERSION}" \
3536
maintainer="SoftwareCollections.org <[email protected]>"
3637

3738
EXPOSE 3306
@@ -51,9 +52,9 @@ RUN INSTALL_PKGS="policycoreutils rsync tar gettext hostname bind-utils groff-ba
5152
ENV CONTAINER_SCRIPTS_PATH=/usr/share/container-scripts/mysql \
5253
MYSQL_PREFIX=/usr
5354

54-
COPY 10.11/root-common /
55-
COPY 10.11/s2i-common/bin/ ${STI_SCRIPTS_PATH}
56-
COPY 10.11/root /
55+
COPY ${MYSQL_VERSION}/root-common /
56+
COPY ${MYSQL_VERSION}/s2i-common/bin/ ${STI_SCRIPTS_PATH}
57+
COPY ${MYSQL_VERSION}/root /
5758

5859
# Hard links are not supported in Testing Farm approach during sync to guest
5960
# operation system. Therefore tests are failing on error

10.11/Dockerfile.rhel10

+12-10
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,13 @@ FROM ubi10/s2i-core
1111
# * $MYSQL_ROOT_PASSWORD (Optional) - Password for the 'root' MySQL account
1212

1313
ENV MYSQL_VERSION=10.11 \
14+
MYSQL_SHORT_VERSION=1011 \
15+
VERSION=${MYSQL_VERSION} \
1416
APP_DATA=/opt/app-root/src \
1517
HOME=/var/lib/mysql \
1618
NAME=mariadb \
17-
VERSION=10.11 \
18-
SUMMARY="MariaDB 10.11 SQL database server" \
19+
VERSION=${MYSQL_VERSION} \
20+
SUMMARY="MariaDB ${MYSQL_VERSION} SQL database server" \
1921
DESCRIPTION="MariaDB is a multi-user, multi-threaded SQL database server. The container \
2022
image provides a containerized packaging of the MariaDB mysqld daemon and client application. \
2123
The mysqld server daemon accepts connections from clients and provides access to content from \
@@ -24,13 +26,13 @@ MariaDB databases on behalf of the clients."
2426
LABEL summary="${SUMMARY}" \
2527
description="${DESCRIPTION}" \
2628
io.k8s.description="${DESCRIPTION}" \
27-
io.k8s.display-name="MariaDB ${VERSION}" \
29+
io.k8s.display-name="MariaDB ${MYSQL_VERSION}" \
2830
io.openshift.expose-services="3306:mysql" \
29-
io.openshift.tags="database,mysql,${NAME},${NAME}1011,${NAME}-1011" \
30-
com.redhat.component="${NAME}-1011-container" \
31-
name="rhel10/${NAME}-1011" \
31+
io.openshift.tags="database,mysql,${NAME},${NAME}${MYSQL_SHORT_VERSION},${NAME}-${MYSQL_SHORT_VERSION}" \
32+
com.redhat.component="${NAME}-${MYSQL_SHORT_VERSION}-container" \
33+
name="rhel10/${NAME}-${MYSQL_SHORT_VERSION}" \
3234
version="1" \
33-
usage="podman run -d -e MYSQL_USER=user -e MYSQL_PASSWORD=pass -e MYSQL_DATABASE=db -p 3306:3306 rhel10/${NAME}-1011" \
35+
usage="podman run -d -e MYSQL_USER=user -e MYSQL_PASSWORD=pass -e MYSQL_DATABASE=db -p 3306:3306 rhel10/${NAME}-${MYSQL_SHORT_VERSION}" \
3436
maintainer="SoftwareCollections.org <[email protected]>"
3537

3638
EXPOSE 3306
@@ -50,9 +52,9 @@ RUN INSTALL_PKGS="policycoreutils rsync tar xz gettext hostname bind-utils groff
5052
ENV CONTAINER_SCRIPTS_PATH=/usr/share/container-scripts/mysql \
5153
MYSQL_PREFIX=/usr
5254

53-
COPY 10.11/root-common /
54-
COPY 10.11/s2i-common/bin/ ${STI_SCRIPTS_PATH}
55-
COPY 10.11/root /
55+
COPY ${MYSQL_VERSION}/root-common /
56+
COPY ${MYSQL_VERSION}/s2i-common/bin/ ${STI_SCRIPTS_PATH}
57+
COPY ${MYSQL_VERSION}/root /
5658

5759
# Hard links are not supported in Testing Farm approach during sync to guest
5860
# operation system. Therefore tests are failing on error

10.11/Dockerfile.rhel9

+11-9
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,12 @@ FROM ubi9/s2i-core
1111
# * $MYSQL_ROOT_PASSWORD (Optional) - Password for the 'root' MySQL account
1212

1313
ENV MYSQL_VERSION=10.11 \
14+
MYSQL_SHORT_VERSION=1011 \
15+
VERSION=${MYSQL_VERSION} \
1416
APP_DATA=/opt/app-root/src \
1517
HOME=/var/lib/mysql \
1618
NAME=mariadb \
17-
SUMMARY="MariaDB 10.11 SQL database server" \
19+
SUMMARY="MariaDB ${MYSQL_VERSION} SQL database server" \
1820
DESCRIPTION="MariaDB is a multi-user, multi-threaded SQL database server. The container \
1921
image provides a containerized packaging of the MariaDB mysqld daemon and client application. \
2022
The mysqld server daemon accepts connections from clients and provides access to content from \
@@ -23,13 +25,13 @@ MariaDB databases on behalf of the clients."
2325
LABEL summary="${SUMMARY}" \
2426
description="${DESCRIPTION}" \
2527
io.k8s.description="${DESCRIPTION}" \
26-
io.k8s.display-name="MariaDB 10.11" \
28+
io.k8s.display-name="MariaDB ${MYSQL_VERSION}" \
2729
io.openshift.expose-services="3306:mysql" \
28-
io.openshift.tags="database,mysql,${NAME},${NAME}1011,${NAME}-1011" \
29-
com.redhat.component="${NAME}-1011-container" \
30-
name="rhel9/${NAME}-1011" \
30+
io.openshift.tags="database,mysql,${NAME},${NAME}${MYSQL_SHORT_VERSION},${NAME}-${MYSQL_SHORT_VERSION}" \
31+
com.redhat.component="${NAME}-${MYSQL_SHORT_VERSION}-container" \
32+
name="rhel9/${NAME}-${MYSQL_SHORT_VERSION}" \
3133
version="1" \
32-
usage="podman run -d -e MYSQL_USER=user -e MYSQL_PASSWORD=pass -e MYSQL_DATABASE=db -p 3306:3306 rhel9/${NAME}-1011" \
34+
usage="podman run -d -e MYSQL_USER=user -e MYSQL_PASSWORD=pass -e MYSQL_DATABASE=db -p 3306:3306 rhel9/${NAME}-${MYSQL_SHORT_VERSION}" \
3335
maintainer="SoftwareCollections.org <[email protected]>"
3436

3537
EXPOSE 3306
@@ -50,9 +52,9 @@ RUN yum -y module enable ${NAME}:${MYSQL_VERSION} && \
5052
ENV CONTAINER_SCRIPTS_PATH=/usr/share/container-scripts/mysql \
5153
MYSQL_PREFIX=/usr
5254

53-
COPY 10.11/root-common /
54-
COPY 10.11/s2i-common/bin/ ${STI_SCRIPTS_PATH}
55-
COPY 10.11/root /
55+
COPY ${MYSQL_VERSION}/root-common /
56+
COPY ${MYSQL_VERSION}/s2i-common/bin/ ${STI_SCRIPTS_PATH}
57+
COPY ${MYSQL_VERSION}/root /
5658

5759
# Hard links are not supported in Testing Farm approach during sync to guest
5860
# operation system. Therefore tests are failing on error

10.5/Dockerfile.c9s

+11-9
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,12 @@ FROM quay.io/sclorg/s2i-core-c9s:c9s
1111
# * $MYSQL_ROOT_PASSWORD (Optional) - Password for the 'root' MySQL account
1212

1313
ENV MYSQL_VERSION=10.5 \
14+
MYSQL_SHORT_VERSION=105 \
15+
VERSION=${MYSQL_VERSION} \
1416
APP_DATA=/opt/app-root/src \
1517
HOME=/var/lib/mysql \
1618
NAME=mariadb \
17-
SUMMARY="MariaDB 10.5 SQL database server" \
19+
SUMMARY="MariaDB ${MYSQL_VERSION} SQL database server" \
1820
DESCRIPTION="MariaDB is a multi-user, multi-threaded SQL database server. The container \
1921
image provides a containerized packaging of the MariaDB mysqld daemon and client application. \
2022
The mysqld server daemon accepts connections from clients and provides access to content from \
@@ -23,13 +25,13 @@ MariaDB databases on behalf of the clients."
2325
LABEL summary="${SUMMARY}" \
2426
description="${DESCRIPTION}" \
2527
io.k8s.description="${DESCRIPTION}" \
26-
io.k8s.display-name="MariaDB 10.5" \
28+
io.k8s.display-name="MariaDB ${MYSQL_VERSION}" \
2729
io.openshift.expose-services="3306:mysql" \
28-
io.openshift.tags="database,mysql,${NAME},${NAME}105,${NAME}-105" \
29-
com.redhat.component="${NAME}-105-container" \
30-
name="sclorg/${NAME}-105-c9s" \
30+
io.openshift.tags="database,mysql,${NAME},${NAME}${MYSQL_SHORT_VERSION},${NAME}-${MYSQL_SHORT_VERSION}" \
31+
com.redhat.component="${NAME}-${MYSQL_SHORT_VERSION}-container" \
32+
name="sclorg/${NAME}-${MYSQL_SHORT_VERSION}-c9s" \
3133
version="1" \
32-
usage="podman run -d -e MYSQL_USER=user -e MYSQL_PASSWORD=pass -e MYSQL_DATABASE=db -p 3306:3306 quay.io/sclorg/${NAME}-105-c9s" \
34+
usage="podman run -d -e MYSQL_USER=user -e MYSQL_PASSWORD=pass -e MYSQL_DATABASE=db -p 3306:3306 quay.io/sclorg/${NAME}-${MYSQL_SHORT_VERSION}-c9s" \
3335
maintainer="SoftwareCollections.org <[email protected]>"
3436

3537
EXPOSE 3306
@@ -50,9 +52,9 @@ RUN yum -y module disable ${NAME} && \
5052
ENV CONTAINER_SCRIPTS_PATH=/usr/share/container-scripts/mysql \
5153
MYSQL_PREFIX=/usr
5254

53-
COPY 10.5/root-common /
54-
COPY 10.5/s2i-common/bin/ ${STI_SCRIPTS_PATH}
55-
COPY 10.5/root /
55+
COPY ${MYSQL_VERSION}/root-common /
56+
COPY ${MYSQL_VERSION}/s2i-common/bin/ ${STI_SCRIPTS_PATH}
57+
COPY ${MYSQL_VERSION}/root /
5658

5759
# Hard links are not supported in Testing Farm approach during sync to guest
5860
# operation system. Therefore tests are failing on error

10.5/Dockerfile.rhel9

+11-9
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,12 @@ FROM ubi9/s2i-core
1111
# * $MYSQL_ROOT_PASSWORD (Optional) - Password for the 'root' MySQL account
1212

1313
ENV MYSQL_VERSION=10.5 \
14+
MYSQL_SHORT_VERSION=105 \
15+
VERSION=${MYSQL_VERSION} \
1416
APP_DATA=/opt/app-root/src \
1517
HOME=/var/lib/mysql \
1618
NAME=mariadb \
17-
SUMMARY="MariaDB 10.5 SQL database server" \
19+
SUMMARY="MariaDB ${MYSQL_VERSION} SQL database server" \
1820
DESCRIPTION="MariaDB is a multi-user, multi-threaded SQL database server. The container \
1921
image provides a containerized packaging of the MariaDB mysqld daemon and client application. \
2022
The mysqld server daemon accepts connections from clients and provides access to content from \
@@ -23,13 +25,13 @@ MariaDB databases on behalf of the clients."
2325
LABEL summary="${SUMMARY}" \
2426
description="${DESCRIPTION}" \
2527
io.k8s.description="${DESCRIPTION}" \
26-
io.k8s.display-name="MariaDB 10.5" \
28+
io.k8s.display-name="MariaDB ${MYSQL_VERSION}" \
2729
io.openshift.expose-services="3306:mysql" \
28-
io.openshift.tags="database,mysql,${NAME},${NAME}105,${NAME}-105" \
29-
com.redhat.component="${NAME}-105-container" \
30-
name="rhel9/${NAME}-105" \
30+
io.openshift.tags="database,mysql,${NAME},${NAME}${MYSQL_SHORT_VERSION},${NAME}-${MYSQL_SHORT_VERSION}" \
31+
com.redhat.component="${NAME}-${MYSQL_SHORT_VERSION}-container" \
32+
name="rhel9/${NAME}-${MYSQL_SHORT_VERSION}" \
3133
version="1" \
32-
usage="podman run -d -e MYSQL_USER=user -e MYSQL_PASSWORD=pass -e MYSQL_DATABASE=db -p 3306:3306 rhel9/${NAME}-105" \
34+
usage="podman run -d -e MYSQL_USER=user -e MYSQL_PASSWORD=pass -e MYSQL_DATABASE=db -p 3306:3306 rhel9/${NAME}-${MYSQL_SHORT_VERSION}" \
3335
maintainer="SoftwareCollections.org <[email protected]>"
3436

3537
EXPOSE 3306
@@ -49,9 +51,9 @@ RUN INSTALL_PKGS="policycoreutils rsync tar gettext hostname bind9.18-utils grof
4951
ENV CONTAINER_SCRIPTS_PATH=/usr/share/container-scripts/mysql \
5052
MYSQL_PREFIX=/usr
5153

52-
COPY 10.5/root-common /
53-
COPY 10.5/s2i-common/bin/ ${STI_SCRIPTS_PATH}
54-
COPY 10.5/root /
54+
COPY ${MYSQL_VERSION}/root-common /
55+
COPY ${MYSQL_VERSION}/s2i-common/bin/ ${STI_SCRIPTS_PATH}
56+
COPY ${MYSQL_VERSION}/root /
5557

5658
# Hard links are not supported in Testing Farm approach during sync to guest
5759
# operation system. Therefore tests are failing on error

0 commit comments

Comments
 (0)