-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imagestream generator #441
Conversation
4f0f663
to
1650502
Compare
[test-openshift] |
@phracek seems like problem with ansible scripts? |
No problem with subscription: |
[test-openshift] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We need an answer for the first question before merging this:
|
@pkubatrh WDYT? |
PHP-7.3 is still supported for RHEL7 images. I don't follow what you mean by removing tag '7.3'? |
There is "7.3-ubi7" and a "7.3" tag. Those are two different tags we provide, the "7.3" being non-standard - not all container images' imagrestreams provide it. Currently the imagestream generator can not generate tags in format of app version only (7.3). |
LGTM. The change might cause some minor breakege, but since we are standardizing on a specific name format I say this is worth the risk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM again.
This PR removes tag "7.3" as it not standard for other sclorg images. I also removes tring
"supports":"php:8.0,php"
from the tag. Could that cause a problem?