Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imagestream generator #441

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Conversation

zmiklank
Copy link
Contributor

@zmiklank zmiklank commented Mar 27, 2024

This PR removes tag "7.3" as it not standard for other sclorg images. I also removes tring "supports":"php:8.0,php" from the tag. Could that cause a problem?

@zmiklank zmiklank force-pushed the imagestream_generator branch from 4f0f663 to 1650502 Compare March 27, 2024 14:32
@zmiklank
Copy link
Contributor Author

[test-openshift]

@zmiklank
Copy link
Contributor Author

zmiklank commented Apr 2, 2024

@phracek seems like problem with ansible scripts?

@phracek
Copy link
Member

phracek commented Apr 2, 2024

@phracek seems like problem with ansible scripts?

No problem with subscription: "The system is unable to complete the requested transaction (HTTP error code 500: Internal Server Error)"

@phracek
Copy link
Member

phracek commented Apr 2, 2024

[test-openshift]

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zmiklank
Copy link
Contributor Author

zmiklank commented Apr 2, 2024

We need an answer for the first question before merging this:

This PR removes tag "7.3" as it not standard for other sclorg images. I also removes tring "supports":"php:8.0,php" from the tag. Could that cause a problem?

@zmiklank
Copy link
Contributor Author

zmiklank commented Apr 4, 2024

We need an answer for the first question before merging this:

This PR removes tag "7.3" as it not standard for other sclorg images. I also removes tring "supports":"php:8.0,php" from the tag. Could that cause a problem?

@pkubatrh WDYT?

@phracek
Copy link
Member

phracek commented Apr 8, 2024

PHP-7.3 is still supported for RHEL7 images. I don't follow what you mean by removing tag '7.3'?

@zmiklank
Copy link
Contributor Author

zmiklank commented Apr 8, 2024

PHP-7.3 is still supported for RHEL7 images. I don't follow what you mean by removing tag '7.3'?

There is "7.3-ubi7" and a "7.3" tag. Those are two different tags we provide, the "7.3" being non-standard - not all container images' imagrestreams provide it. Currently the imagestream generator can not generate tags in format of app version only (7.3).

@pkubatrh
Copy link
Member

pkubatrh commented Apr 8, 2024

LGTM. The change might cause some minor breakege, but since we are standardizing on a specific name format I say this is worth the risk.

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again.

@zmiklank zmiklank merged commit f8bf2b4 into sclorg:master Apr 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants