Skip to content

Commit c9de4b8

Browse files
committed
fix links
1 parent 4d644d5 commit c9de4b8

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

docs/adr/001_error_handling.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@ We will focus on the exporter traits in this example, but the outcome should be
1414

1515
There are various ways to handle errors on trait methods, including swallowing them and logging, panicing, returning a shared global error, or returning a method-specific error. We strive for consistency, and we want to be sure that we've put enough thought into what this looks like that we don't have to make breaking interface changes unecessarily in the future.
1616

17-
This was discussed extensively in #2571.
17+
This was discussed extensively in [#2571](https://github.com/open-telemetry/opentelemetry-rust/issues/2571).
1818

1919

2020
## Related Work
2121

22-
* #2564
23-
* #2561
24-
* #2381
22+
* [#2564](https://github.com/open-telemetry/opentelemetry-rust/issues/2564)
23+
* [#2561](https://github.com/open-telemetry/opentelemetry-rust/issues/2561)
24+
* [#2381](https://github.com/open-telemetry/opentelemetry-rust/issues/2381)
2525

2626
## Considered Options
2727

@@ -45,7 +45,7 @@ Our preference for error types is thus:
4545
1. Devolves into error type per method of a particular trait type (e.g., `SdkShutdownResult`, `SdkExportResult`) _if the error types need to diverge_
4646
1. May alternatively devolve into error type per signal (e.g., `SpanExporter`) if the _signals diverge_
4747

48-
This approach generalises across both **signals** and **trait methods**. For example, returning to our exporter traits, we have a trait that looks the same for each signal, with the same three methods. Upon closer inspection (#2600), the potential error set is the same both between the methods *and* between the signals; this means we can use a single shared error type across both axes:
48+
This approach generalises across both **signals** and **trait methods**. For example, returning to our exporter traits, we have a trait that looks the same for each signal, with the same three methods. Upon closer inspection ([#2600](https://github.com/open-telemetry/opentelemetry-rust/issues/2600)), the potential error set is the same both between the methods *and* between the signals; this means we can use a single shared error type across both axes:
4949

5050
```rust
5151

0 commit comments

Comments
 (0)