Skip to content

Commit 0c8f3eb

Browse files
authored
Merge pull request #5 from scrum-for-developers/feature/wb-117
validate isbn 13
2 parents d271c96 + 5c20915 commit 0c8f3eb

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

worblehat-web/src/main/java/de/codecentric/psd/worblehat/web/validation/ISBNConstraintValidator.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ public boolean isValid(String value, ConstraintValidatorContext context) {
1212
// Don't validate null, empty and blank strings, since these are validated by @NotNull,
1313
// @NotEmpty and @NotBlank
1414
if (StringUtils.isNotBlank(value)) {
15-
return ISBNValidator.getInstance().isValidISBN10(value);
15+
return ISBNValidator.getInstance().isValidISBN10(value)
16+
|| ISBNValidator.getInstance().isValidISBN13(value);
1617
}
1718
return true;
1819
}

worblehat-web/src/main/resources/ValidationMessages.properties

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,21 +5,21 @@ empty.bookDataFormData.edition=Edition is mandatory
55
empty.bookDataFormData.author=Author is mandatory
66
empty.bookDataFormData.isbn=ISBN is mandatory
77
notvalid.bookDataFormData.edition=Please enter a numeric value.
8-
notvalid.bookDataFormData.isbn=Please enter a valid 10 characters ISBN.
8+
notvalid.bookDataFormData.isbn=Please enter a valid 10 or 13 characters ISBN.
99
notvalid.bookDataFormData.yearOfPublication=Please enter a four-digit year.
1010
invalid.length.bookDataFormData.yearOfPublication=Please enter a four-digit year.
1111

1212
# Borrow book form
13-
notvalid.borrowCmd.isbn=Please enter a valid 10 characters ISBN.
13+
notvalid.borrowCmd.isbn=Please enter a valid 10 or 13 characters ISBN.
1414
empty.borrowCmd.isbn=ISBN is mandatory
1515
notvalid.borrowCmd.email=Please enter a valid Email.
1616
empty.borrowCmd.email=Email is mandatory
1717

1818
# Return all books form
1919
empty.returnAllBookFormData.emailAddress=Email is mandatory
2020
notvalid.returnAllBookFormData.emailAddress=Please enter a valid Email.
21-
notvalid.returnAllBookFormData.isbn=Please enter a valid 10 characters ISBN.
21+
notvalid.returnAllBookFormData.isbn=Please enter a valid 10 or 13 characters ISBN.
2222

2323
# Default messages for custom validators
24-
de.codecentric.psd.worblehat.web.validation.ISBN=Please enter a valid 10 characters ISBN.
24+
de.codecentric.psd.worblehat.web.validation.ISBN=Please enter a valid 10 or 13 characters ISBN.
2525
de.codecentric.psd.worblehat.web.validation.Numeric=Value has to be numeric

0 commit comments

Comments
 (0)