-
-
Notifications
You must be signed in to change notification settings - Fork 4
TypeError: Cannot read property 'includes' of undefined #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@gitscrum , I've put together a minimal reproduction repo at https://github.com/MaxMilton/reproduce-postcssatrulesvars-bug. I done some playing around and I think the culprit behind this bug is variables which are commented out. Sounds a bit strange, I know, but clone my repo and try running it with and without the comment in the CSS. |
Upon more testing I've found it happen whenever there's a comment on the line, it doesn't matter if the variable itself is commented or if there's a trailing comment, both result in the error. Example: :root {
/* --variable: true; */
} :root {
--variable: true; /* comment */
} |
@maxmilton Thanks for your research, they help me to look in the right direction. I will try to understand this quickly. |
@maxmilton Thank you for this bug. All is fixed. We will wait for you from new bugs / offers / pool of requests :) Please do not forget to put the star projects that you like)) |
Nice! Thank you. Tested and it's now working as expected 🌟 💯 |
based on #181 (comment)
Nice 😄
However, I just tested it and I now get this error:
The text was updated successfully, but these errors were encountered: