fix using Windows ProxyOverride registry value as a NO_PROXY (#2559)

Closes #1444

Author: Fizcko

Cargo.toml

@@ -181,7 +181,7 @@ futures-util = { version = "0.3.28", default-features = false, features = ["std"
 rustls = { version = "0.23", default-features = false, features = ["ring"] }
 
 [target.'cfg(windows)'.dependencies]
-windows-registry = "0.2"
+windows-registry = "0.4"
 
 [target.'cfg(target_os = "macos")'.dependencies]
 system-configuration = { version = "0.6.0", optional = true }

src/proxy.rs

@@ -29,6 +29,9 @@ use system_configuration::{
     sys::schema_definitions::kSCPropNetProxiesHTTPSProxy,
 };
 
+#[cfg(target_os = "windows")]
+use windows_registry::CURRENT_USER;
+
 /// Configuration of a proxy that a `Client` should pass requests to.
 ///
 /// A `Proxy` has a couple pieces to it:
@@ -280,6 +283,13 @@ impl Proxy {
             get_from_platform(),
         ))));
         proxy.no_proxy = NoProxy::from_env();
+
+        #[cfg(target_os = "windows")]
+        {
+            let win_exceptions: String = get_windows_proxy_exceptions();
+            proxy.no_proxy = NoProxy::from_string(&win_exceptions);
+        }
+
         proxy
     }
 
@@ -1136,6 +1146,24 @@ fn parse_platform_values(platform_values: String) -> SystemProxyMap {
     parse_platform_values_impl(platform_values)
 }
 
+#[cfg(target_os = "windows")]
+fn get_windows_proxy_exceptions() -> String {
+    let mut exceptions = String::new();
+    if let Ok(key) =
+        CURRENT_USER.create(r"Software\Microsoft\Windows\CurrentVersion\Internet Settings")
+    {
+        if let Ok(value) = key.get_string("ProxyOverride") {
+            exceptions = value
+                .split(';')
+                .map(|s| s.trim())
+                .collect::<Vec<&str>>()
+                .join(",")
+                .replace("*.", "");
+        }
+    }
+    exceptions
+}
+
 #[cfg(test)]
 mod tests {
     use super::*;