Fix default value of cacheResult XML configuration attribute

sebastianbergmann · sebastianbergmann · commit a89b9ae0b972 · 2020-08-10T07:58:36.000+02:00
diff --git a/ChangeLog-9.3.md b/ChangeLog-9.3.md
@@ -13,6 +13,7 @@ All notable changes of the PHPUnit 9.3 release series are documented in this fil
 ### Fixed
 
 * [#4405](https://github.com/sebastianbergmann/phpunit/issues/4405): Location for (current version of) XML Schema for XML configuration file has changed
+* Default value for `<phpunit cacheResult="true|false">` XML configuration attribute was `false` instead of `true`
 
 ## [9.3.3] - 2020-08-08
 
diff --git a/src/TextUI/XmlConfiguration/Loader.php b/src/TextUI/XmlConfiguration/Loader.php
@@ -1002,7 +1002,7 @@ private function phpunit(string $filename, DOMDocument $document): PHPUnit
         }
 
         return new PHPUnit(
-            $this->getBooleanAttribute($document->documentElement, 'cacheResult', false),
+            $this->getBooleanAttribute($document->documentElement, 'cacheResult', true),
             $cacheResultFile,
             $this->getColumns($document),
             $this->getColors($document),

Original file line number	Diff line number	Diff line change
`@@ -1002,7 +1002,7 @@ private function phpunit(string $filename, DOMDocument $document): PHPUnit`
`1002`	`1002`	`}`
`1003`	`1003`
`1004`	`1004`	`return new PHPUnit(`
`1005`		`- $this->getBooleanAttribute($document->documentElement, 'cacheResult', false),`
	`1005`	`+ $this->getBooleanAttribute($document->documentElement, 'cacheResult', true),`
`1006`	`1006`	`$cacheResultFile,`
`1007`	`1007`	`$this->getColumns($document),`
`1008`	`1008`	`$this->getColors($document),`